perf(ci): stage expensive checks without removing qualification - #2865
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03044029c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Hosted self-tests exposed the older explicit no-frontend dependency rule. Retain the callee's independent runtime setup checks and assert the new reviewed prerequisites without weakening PR-only secret-scan isolation. Refs #2327
|
Independent review and single fix-round checkpoint Reviewed this slice with an independent Terra reader, then reviewed only the blocking fix diff. Current head: 49711f1. The integrated final tree is byte-identical to independently reviewed 636a17329e5a480d702fcf1a9585cf279bbf60fb after preserving each original stack branch and propagating fixes with merge commits. Blocking changes: prohibit Git lazy fetch/protocol execution in immutable readers; use independently trusted self-contained export verification; repair Windows CRLF and privilege-free symlink fixtures. Slice-specific changes remain visible in this PR diff. No result-reuse activation or settings changes. Validation: cumulative Windows control command node --test scripts/ci/smart-ci/*.test.mjs passed 509/509, no failures/skips/cancellations. Independent fix checks: core/repository 110/110; export/workflow 11/11. node scripts/check-doc-links.mjs passed, 683 Markdown files and zero broken relative links. These are additive; hosted CI at the current head/base is still required. Nonblocking findings are tracked once on #2336: #2336 (comment) . Review budget: one original pass and one scoped fix verification, complete. Original E2E/nightly-map findings were already corrected in the previous authored heads and remain covered by the green control tests. The maintainer's current local request explicitly includes finishing and merging this CI work. Parent-first merge order remains #2863, #2864, #2865, #2867, #2868, #2869, #2871; children are retargeted only after parents land, with moved-base requalification. No branch deletion while it is a stack base. |
|
Parent #2864 merged as c6a97b7 at03:49:33UTC after exact-head required CI34432658977 success and zero pending/failed/open review threads. This PR now targets main; API base confirmation succeeded. gh pr update-branch refreshed head to e9a78e3. git diff --exit-code against reviewed49711f1f34cb45f8a6d855ef826235443b2fb3d5 passed: source tree unchanged, code review remains applicable; fresh full hosted qualification is running before merge. |
1 participant
Stack
Depends on #2864 (which depends on #2863). Merge parents first and retarget only after they actually land. R4: maintainer + independent fresh-context review required under SC-10; do not auto-merge.
Change
Apply the guarded
minimaldependency-only transform toci-required.yml: cheap architecture/release/paper checks precede relevant expensive work; E2E additionally waits for Frontend Unit. API does not wait for the entire backend unit platform matrix. Security scans stay independent, including the PR-only Gitleaks event guard.No jobs, commands, matrices, names, pins, permissions, triggers or concurrency rules are removed/changed. All 13 top-level jobs are retained. No selective omission, result reuse, main-push removal, Windows reduction or settings change is introduced. This aims to avoid failed-candidate waste, not to promise faster healthy-candidate latency.
Validation
Original workflow reconstructed from the connector and verified against exact Git blob
f056d76a0c1b4ecabd95783d47131dfe096121c5. Before/after content withneedsblocks removed is byte-identical. PyYAML syntax sanity check passed; this is not a substitute for Actionlint.node --test scripts/ci/smart-ci/continuation.test.mjs: 257 passed, 0 failed/skipped/cancelled, local Node 22.16.0/Linux. Four added tests read the checked-in workflow; existing adversarial transformer tests exercise cycles, ambiguous syntax, lost dependencies and overwrite refusal.Exact-head hosted required CI, Actionlint/configured-Node validation and independent review remain required. No full Taskdeck product run or post-deployment savings measurement is claimed locally. Parent #2863's Smart CI Self-Test and CI Extended were observed successful while its full CI was still running; those parent outcomes do not qualify this head.
Docs / coordination / rollback
docs/ci/continuation/STAGING.mdrecords the dependencies, trade-offs, measurement method and rollback. Shared-path claim is on #2327 (comment 5610684973). #2838/#2840 checkout hardening and #2858 launcher code are untouched. Canonical docs remain coordinator-owned.Rollback by reversing only these
needsadditions, not restoring an old whole workflow over later hardening. All human administrative/review gates remain open.Refs #2327, #2332.