[test-qa-hourly] test: classify missing canonical jobs as unknown - #435
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Hourly QA update — CI-first repairInspection
Root cause#434 intentionally tightened cross-subject image fallback: a donor Brave query must share a concrete term with the borrowing scene query. The new Action
Commands / results
Auto-mergeNot enabled: repository setting |
Hourly QA update — CI-first repairInspection
CI repairOnly minimal changes required by the failing gates were made:
Commands / results
Auto-mergeNot enabled. Repository setting is Next QA target after CI is greenCanonical |
Hourly QA update — CI-first repairInspected the current QA PR, latest CI #2466 root cause
bash scripts/verify-jobs.sh type-check lint deadcode dupResults:
bash scripts/verify-jobs.sh format repo contractsResults:
Fixes on this run
Coverage path remains unchanged: Local focused validation was attempted through the configured DevSpace connectors, but both returned New head CI: #2468 / 34377788654 — pending. Auto-merge remains disabled because the repository setting is Next QA target after green CI: canonical |
Hourly QA update — 2026-09-10CI-first run. Reused this open Inspection
ActionMinimal CI repair only:
Commit diff verification shows the functional change is exactly the one type alias line; the second commit is newline-only. No workflow/docs/ignore/threshold changes. Commands / results
Auto-mergeNot enabled. Repository setting is Next QA targetOnce CI is green, return to the planned waitlist regression: canonical |
Hourly QA updateCI-first run on head Inspection
Action
Validation
Auto-merge remains disabled unless the updated head is fully green and repository policy permits it. |
Hourly QA updateCI-first run against GitHub source of truth. Inspection
CI failure investigatedRun #2471 (
The only errors were three TS2345 failures in FixCommit
No CI gates, workflow behavior, docs, ignores, coverage thresholds, mocks, or unrelated behavior were changed. Commit diff was reviewed after the write. Commands / results
Auto-mergeNot enabled. Updated-head CI has not passed yet, so enabling it would be premature even if repository policy allowed it. Next QA targetOnce CI is green, return to the planned waitlist regression: make canonical |
QA run update — 2026-09-10Inspection
ChangeAdded one regression to
Commit: No production code, workflow, docs, ignores, thresholds, or unrelated refactors changed in this run. Commands / resultsGitHub-source-of-truth checks performed:
Updated-head validation: CI #2473 ( Auto-mergeNot enabled: updated-head required CI has not completed yet. No branch protection or review requirement will be bypassed. Next QA targetOnce this head is green, inspect whether |
Hourly QA update — 2026-09-10 13:33 JSTInspection
ChangeCommit Strengthened the existing zero-view regression with an exact-YouTube case:
Only Commands / validation
Auto-mergeNot enabled. Updated-head CI is not green yet, PR is currently reported non-mergeable while behind main, and repository Next QA targetIf CI #2491 is green, inspect estimated (non-YouTube) follower attribution around zero-total-reach and mixed zero/non-zero observations, then move to the next uncovered |
Test QA run updateCI-first run. Reused this ongoing QA PR and inspected the current head, active diff, workflow run, quick-gate artifact, relevant zero-view regression test, and divergence from CI investigation
Change
Commands / results
Auto-mergeNot enabled: updated-head CI is not green yet. No protections were bypassed. Next QA targetOnce #2492 is green, inspect estimated (non-YouTube) follower attribution around zero total reach / mixed zero-and-nonzero reach, then choose one uncovered regression-prone aggregation branch only if the existing tests do not already pin it. |
Hourly Test QA — 2026-09-10 15:33 JSTInspection
Safe sync with main
QA changeCommit: Added one regression case to
Validation / commands and resultsNo local shell/DevSpace execution is available in this connector session, so PR CI remains the authoritative executable validation. GitHub-side validation performed:
Auto-mergeNot enabled. Updated-head CI is not green yet, and repository setting Next QA targetAfter CI #2494 is green: inspect mixed zero/nonzero reach under estimated attribution, especially whether total-reach aggregation and follower-efficiency stay correct when one attributed post has zero reach and another has positive reach. Only add a test if that behavior is not already directly covered. |
Test QA run — 2026-09-10Inspection
ChangeCommit Added one regression case to
No production code, workflow, docs, ignores, thresholds, or unrelated refactors changed. Commands / validation
Auto-mergeNot enabled: updated-head CI is not green yet, and the branch is not currently mergeable with Next QA targetAfter #2495 is green, inspect the attribution split when zero-reach posts have engagement/profile activity versus reach-bearing posts, especially whether per-post estimated shares and aggregate efficiency remain internally consistent without double-counting. |
Hourly QA update — 2026-09-10Inspection
CI-first root causePrevious head
The behavior was correct; the new test used exact equality for floating-point estimated attribution. Received values were ActionCommit Only the regression test changed. Structural assertions ( Commands / results
Auto-mergeNot enabled. Updated-head CI is not green yet, and the branch is currently one automated snapshot commit behind Next QA targetAfter #2496 is green, inspect the per-post estimated attribution split when a zero-reach post still has engagement/profile activity, looking for double-counting or aggregate/per-post inconsistency before adding any further regression. |
Hourly QA update — 2026-09-10Inspection
ChangeAdded one regression test to
Commit: No production implementation, workflow, docs, CI gates, ignores, mocks, or coverage thresholds changed. Commands / validation
Auto-mergeNot enabled: updated-head CI has not completed yet. No branch protection is being bypassed. Next QA targetAfter #2497 is green, inspect another data-quality boundary in follower attribution: baseline rows marked |
Hourly Test QA — 2026-09-10Inspection
SyncSafely merged QA changeAdded The regression pins a separate fail-soft boundary from the prior endpoint test: if the observation exactly at the follower interval boundary is No production implementation, workflow, docs, ignores, thresholds, mocks, or unrelated refactors were changed. Validation / commands and results
Auto-mergeNot enabled: the updated-head CI is still pending. Repository setting Next QA targetIf #2499 is green, inspect exact YouTube follower attribution for the analogous data-quality edge: a standardized row marked |
Hourly Test QA — 2026-09-10 20:31 JSTInspection
Finding / change
Minimal fix + regression:
Validation / commands and resultsNo local shell workspace is available in this connector session, so executable validation is delegated to repository CI rather than fabricating a local result. GitHub source-of-truth checks performed:
Auto-mergeNot enabled: updated-head CI is still pending. I also did not bypass protections or merge while validation is incomplete. Next QA targetIf #2501 is green, inspect exact YouTube selection for malformed/non-finite |
Hourly QA update — 2026-09-10Inspection:
Change:
Validation / commands:
Auto-merge:
Next QA target after green CI:
|
Hourly QA update — 2026-09-10Inspection
ActionAdded one regression assertion to Final change commit: During investigation I also created a temporary probe for unavailable standardized 24h rows, which revealed a separate plausible Growth data-quality target ( Commands / validation
Auto-mergeNot enabled: latest-head CI is still pending. Do not bypass repository protections. Next QA targetAfter #2505 is green, investigate standardized 24h Growth aggregation with |
QA scope
Adds one focused regression test for waitlist attribution when a persisted
social_publish_job_idpoints to a canonical publish job that no longer exists. The expected behavior is fail-soft classification as direct/unknown while preserving persisted signup totals and emitting no conversion row.Source-of-truth inspection
57253aeeb7e2ad3fb9f532c3b656191bad309e78(merge of QA PR [test-qa-hourly] test: preserve legacy waitlist attribution #433), immediately after integration PR Integration/pr 429 432 rollup #434..github/workflows/ci.yml; quick gates remainformat repo contracts, quality gatestype-check lint deadcode dup, teststest analytics, with E2E/security/deploy gates unchanged.scripts/coverage.sh/ coverage search;pnpm coverage summaryremainsturbo run test:coveragefollowed byscripts/coverage-summary.ts.test.skip,it.skip,describe.skip, todo, or focused-test matches found.apps/control-center/src/server/services/waitlist-growth.ts; attribution only occurs when the canonical job exists injobsById, so a dangling job ID is intentionally counted as unknown.waitlist-growth-batching.test.ts; batching, pagination, and seven-day boundary are covered, but the dangling canonical-job case was not directly pinned.Change
apps/control-center/src/server/services/waitlist-growth-missing-job.test.ts.Commands / validation
Focused local validation could not be started because the authenticated local DevSpace connector returned
We couldn't connect your account; no repository file was modified through that failed path. The change was therefore made directly against GitHub source of truth.GitHub inspection calls completed successfully for recent commits, open PRs, CI workflow, coverage scripts/search, implementation, and related tests. PR CI is the authoritative validation for this head and will be recorded in the next QA update.