Skip to content

[test-qa-hourly] test: cover impressions reach fallback - #440

Merged
i-xtsu-sixyou-ken-mei merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260910
Sep 10, 2026
Merged

[test-qa-hourly] test: cover impressions reach fallback#440
i-xtsu-sixyou-ken-mei merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260910

Conversation

@i-xtsu-sixyou-ken-mei

Copy link
Copy Markdown
Collaborator

QA scope

Adds one focused regression test for social follower attribution when a provider has no views value but does have cumulative impressions. The existing implementation intentionally falls back from views to impressions for reach; this test pins that behavior so a future refactor cannot silently turn valid X-style reach telemetry into null attribution.

Source-of-truth inspection

Change

  • Added apps/control-center/src/server/services/social-attribution-impressions.test.ts.
  • No production code, workflow, docs, thresholds, mocks, ignores, or unrelated refactors changed.

Commands / validation

  • GitHub source-of-truth inspection — PASS.
  • Local focused validation attempt via the authenticated DevSpace connector — BLOCKED by transient account connection error (We couldn't connect your account). No local repository files were modified.
  • PR CI — pending; authoritative executable validation for this head.

Next QA target

After CI is green, inspect standardized 24h growth metrics for collection_status='unavailable': metrics24hForPostIds() currently filters post/window but not collection status, while the standardized query also does not filter collected rows. Verify whether unavailable rows can inflate samples/reach/engagement before making any minimal consumer/query fix.

@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei merged commit 5271fbc into main Sep 10, 2026
11 of 12 checks passed
@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei deleted the test-qa/ongoing-coverage-20260910 branch September 10, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant