[test-qa-hourly] test: cover impressions reach fallback - #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA scope
Adds one focused regression test for social follower attribution when a provider has no
viewsvalue but does have cumulativeimpressions. The existing implementation intentionally falls back from views to impressions for reach; this test pins that behavior so a future refactor cannot silently turn valid X-style reach telemetry intonullattribution.Source-of-truth inspection
main: latest checked commite7a1edb593ee6824ad76fb3feb1ad63787832d86(docs: reconcile Control Center operational truth (#436)), immediately after merged hourly QA PR [test-qa-hourly] test: classify missing canonical jobs as unknown #435.test-qa/ongoing-coverage-20260910from currentmain..github/workflows/ci.ymlstill runs quick gates (format repo contracts), code quality (type-check lint deadcode dup), tests (test analytics), plus E2E/security/deploy gates.scripts/coverage.shstill runsturbo run test:coveragefollowed bytsx scripts/coverage-summary.tsfor the summary command.computePostActivity()usesviews ?? impressionsfor reach and clamps cumulative counter deltas.social-attribution.test.tscovers baseline/endpoints, resets, unavailable observations, virtual-zero posts, weighting, churn, and YouTube exact attribution, but did not directly pin impressions fallback.Change
apps/control-center/src/server/services/social-attribution-impressions.test.ts.Commands / validation
We couldn't connect your account). No local repository files were modified.Next QA target
After CI is green, inspect standardized 24h growth metrics for
collection_status='unavailable':metrics24hForPostIds()currently filters post/window but not collection status, while the standardized query also does not filter collected rows. Verify whether unavailable rows can inflate samples/reach/engagement before making any minimal consumer/query fix.