Skip to content

Don't restrict pins from non pin dropdowns in UM settings (V16.x) - #5760

Merged
DedeHai merged 1 commit into
wled:16_xfrom
DedeHai:UM_pinlist_fix_16_x
Jul 29, 2026
Merged

Don't restrict pins from non pin dropdowns in UM settings (V16.x)#5760
DedeHai merged 1 commit into
wled:16_xfrom
DedeHai:UM_pinlist_fix_16_x

Conversation

@DedeHai

@DedeHai DedeHai commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Fix for #5759

Summary by CodeRabbit

  • Bug Fixes
    • Improved settings behavior by ensuring pin-selection updates only run for relevant controls.
    • Prevented unrelated input changes from triggering unnecessary pin option updates.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c65dfeeb-fe12-4b25-a0b9-7711b1f5d05e

📥 Commits

Reviewing files that changed from the base of the PR and between 143e37b and 5ec1cdd.

📒 Files selected for processing (1)
  • wled00/data/settings_um.htm

Walkthrough

The settings UI now filters UI(e) events by the pin CSS class, preventing pin-dropdown synchronization from running for unrelated inputs.

Changes

Pin Dropdown Event Handling

Layer / File(s) Summary
Filter pin dropdown events
wled00/data/settings_um.htm
UI(e) exits early for non-pin elements before running pin option synchronization.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by describing the UM settings pin-dropdown restriction fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DedeHai
DedeHai merged commit 7230b2c into wled:16_x Jul 29, 2026
26 checks passed
@DedeHai
DedeHai deleted the UM_pinlist_fix_16_x branch July 29, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant