Skip to content

Don't restrict pins from non pin dropdowns in UM settings - #5761

Merged
DedeHai merged 1 commit into
wled:mainfrom
DedeHai:UM_pinlist_fix
Jul 29, 2026
Merged

Don't restrict pins from non pin dropdowns in UM settings#5761
DedeHai merged 1 commit into
wled:mainfrom
DedeHai:UM_pinlist_fix

Conversation

@DedeHai

@DedeHai DedeHai commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Fix for #5759

Summary by CodeRabbit

  • Bug Fixes
    • Prevented non-pin controls from unintentionally changing pin selection options in the usermod settings interface.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e39b0d6f-e53b-444e-9e58-0909ac5a4687

📥 Commits

Reviewing files that changed from the base of the PR and between 8db3d7a and 25e9270.

📒 Files selected for processing (1)
  • wled00/data/settings_um.htm

Walkthrough

The usermod settings UI(e) handler now ignores events from elements without the pin CSS class before synchronizing select options.

Changes

Usermod settings event handling

Layer / File(s) Summary
Filter non-pin UI events
wled00/data/settings_um.htm
UI(e) returns immediately for non-pin controls, limiting option synchronization to pin dropdown events.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • wled/WLED#5760: Updates the same UI(e) handler with equivalent pin-class event filtering.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main fix: preventing pin restrictions from affecting non-pin dropdowns in usermod settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@softhack007 softhack007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

maybe also check for "gpio" to keep support for the deep slepp usermod (if the rabbit statement is correct)

One detail to handle: DeepSleep:gpio is a real GPIO dropdown, but its field name is gpio, not something containing pin. It currently does not receive the .pin class.

@softhack007 softhack007 linked an issue Jul 29, 2026 that may be closed by this pull request
1 task
@DedeHai

DedeHai commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

the rabbit was wrong about deep sleep, I made it gpio intentionally exactly for the reason to be able to select a pin that is for example used by a button in normal use.

@DedeHai

DedeHai commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

I tested this using AR, multirely and deep sleep UMs and all dropdowns are now correct

@DedeHai
DedeHai merged commit 16f2b9c into wled:main Jul 29, 2026
33 checks passed
@DedeHai
DedeHai deleted the UM_pinlist_fix branch July 29, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UM settings non-pinlists still reserve pins

2 participants