Don't restrict pins from non pin dropdowns in UM settings - #5761
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe usermod settings ChangesUsermod settings event handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
looks good to me 👍
maybe also check for "gpio" to keep support for the deep slepp usermod (if the rabbit statement is correct)
One detail to handle: DeepSleep:gpio is a real GPIO dropdown, but its field name is gpio, not something containing pin. It currently does not receive the .pin class.
|
the rabbit was wrong about deep sleep, I made it gpio intentionally exactly for the reason to be able to select a pin that is for example used by a button in normal use. |
|
I tested this using AR, multirely and deep sleep UMs and all dropdowns are now correct |
Fix for #5759
Summary by CodeRabbit