Skip to content

chore: migrate lint and format to Rstack CLI - #1884

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-cli-lint-format
Aug 30, 2026
Merged

chore: migrate lint and format to Rstack CLI#1884
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-cli-lint-format

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

This PR consolidates repository linting and formatting under Rstack CLI while leaving the build and test toolchains unchanged.

  • Move the existing Rslint and Prettier behavior into rstack.config.ts, and update scripts, staged-file tasks, and editor settings to use rs lint and rs fmt.
  • Add the version-matched rstack-cli-docs Skill and update contributor guidance.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI lite review requested due to automatic review settings August 30, 2026 04:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T04:56:03.778164Z aab96a0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aab96a0dc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-lock.yaml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates repository linting and formatting to Rstack CLI by moving lint/format configuration into rstack.config.ts and updating scripts and editor integration to use rs lint / rs fmt.

Changes:

  • Replace the standalone Rslint/Prettier setup with define.lint() / define.fmt() in rstack.config.ts.
  • Update package.json scripts and nano-staged tasks to run rs lint and rs fmt.
  • Switch VS Code defaults/recommendations to the Rstack extension and remove Prettier config files.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rstack.config.ts Registers lint/format behavior via Rstack define.*() APIs.
pnpm-workspace.yaml Drops @rslint/core + prettier-plugin-packagejson from the catalog and adds rstack.
pnpm-lock.yaml Lockfile updates reflecting the dependency/tooling migration to rstack.
package.json Updates scripts and nano-staged tasks to use rs lint / rs fmt; swaps dev deps accordingly.
CONTRIBUTING.md Updates contributor guidance to reference Rstack CLI and the Rstack VS Code extension.
AGENTS.md Updates agent-facing repo guidance to reflect Rstack as the canonical lint/format tool.
.vscode/settings.json Sets Rstack as the default formatter in VS Code settings.
.vscode/extensions.json Recommends the Rstack extension instead of Rslint/Prettier extensions.
.prettierrc.json Removes Prettier config now superseded by define.fmt().
.prettierignore Removes Prettier ignore file now superseded by rs fmt behavior/config.
.agents/skills/rstack-cli-docs/SKILL.md Adds a version-matched skill entry for consulting Rstack CLI docs.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Suppressed comments (1)

rstack.config.ts:70

  • rs fmt does not load .prettierignore, and .gitignore rules are not applied to files passed explicitly (e.g., from nano-staged). Add ignorePatterns so generated artifacts remain excluded even when passed as direct file arguments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
@chenjiahan
chenjiahan merged commit 2bd0087 into main Aug 30, 2026
12 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-rstack-cli-lint-format branch August 30, 2026 07:48
@chenjiahan chenjiahan mentioned this pull request Aug 30, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants