chore: migrate lint and format to Rstack CLI - #1884
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aab96a0dc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR migrates repository linting and formatting to Rstack CLI by moving lint/format configuration into rstack.config.ts and updating scripts and editor integration to use rs lint / rs fmt.
Changes:
- Replace the standalone Rslint/Prettier setup with
define.lint()/define.fmt()inrstack.config.ts. - Update
package.jsonscripts andnano-stagedtasks to runrs lintandrs fmt. - Switch VS Code defaults/recommendations to the Rstack extension and remove Prettier config files.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rstack.config.ts | Registers lint/format behavior via Rstack define.*() APIs. |
| pnpm-workspace.yaml | Drops @rslint/core + prettier-plugin-packagejson from the catalog and adds rstack. |
| pnpm-lock.yaml | Lockfile updates reflecting the dependency/tooling migration to rstack. |
| package.json | Updates scripts and nano-staged tasks to use rs lint / rs fmt; swaps dev deps accordingly. |
| CONTRIBUTING.md | Updates contributor guidance to reference Rstack CLI and the Rstack VS Code extension. |
| AGENTS.md | Updates agent-facing repo guidance to reflect Rstack as the canonical lint/format tool. |
| .vscode/settings.json | Sets Rstack as the default formatter in VS Code settings. |
| .vscode/extensions.json | Recommends the Rstack extension instead of Rslint/Prettier extensions. |
| .prettierrc.json | Removes Prettier config now superseded by define.fmt(). |
| .prettierignore | Removes Prettier ignore file now superseded by rs fmt behavior/config. |
| .agents/skills/rstack-cli-docs/SKILL.md | Adds a version-matched skill entry for consulting Rstack CLI docs. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
rstack.config.ts:70
rs fmtdoes not load.prettierignore, and.gitignorerules are not applied to files passed explicitly (e.g., from nano-staged). AddignorePatternsso generated artifacts remain excluded even when passed as direct file arguments.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
This PR consolidates repository linting and formatting under Rstack CLI while leaving the build and test toolchains unchanged.
rstack.config.ts, and update scripts, staged-file tasks, and editor settings to users lintandrs fmt.rstack-cli-docsSkill and update contributor guidance.Related Links
Checklist