chore: check formatting in CI - #1886
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI “check” step intended to prevent formatting regressions from merging, while applying repository-wide formatting adjustments to satisfy the new rules.
Changes:
- Add a new root
checkscript and switch the CI workflow fromlinttocheck. - Apply formatter-driven code style updates across core TS sources/tests and docs tables.
- Remove the redundant
sort-package-jsonscript.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/migration/tsup.mdx | Reformat the tsup→Rslib mapping table to match formatter output. |
| website/docs/en/guide/migration/tsup.mdx | Reformat the tsup→Rslib mapping table to match formatter output. |
| packages/core/tests/syntax.test.ts | Formatter-driven line wrapping/compaction in tests. |
| packages/core/src/utils/syntax.ts | Formatter-driven parenthesization in a ternary/nullish-coalescing return. |
| packages/core/src/css/libCssExtractLoader.ts | Formatter-driven union type formatting. |
| packages/core/src/config.ts | Formatter-driven chaining/object formatting. |
| package.json | Add check script; remove sort-package-json. |
| .github/workflows/lint.yml | Run pnpm run check instead of pnpm run lint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Deploying rslib with
|
| Latest commit: |
76bc197
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a575c04.rslib.pages.dev |
| Branch Preview URL: | https://chenjiahan-chore-rs-check-ci.rslib.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds formatting verification to CI so formatting regressions fail before merge.
checkscript backed byrs check --type-check, and run it in CI to preserve lint and type checking while addingrs fmt --check.sort-package-jsonscript.Related Links
Checklist