Skip to content

test(e2e): match the failed-deploy reason across Docker versions #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vazra merged 1 commit into from
Oct 11, 2026
Merged

test(e2e): match the failed-deploy reason across Docker versions #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions e2e/tests/20-activity.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ test.describe('Activity changelog', () => {
await expect(row).toContainText(`Deploy failed: ${failed.error}`);
await expect(row.locator('.text-red-400, details summary').filter({ hasText: failed.error.slice(0, 100) })).toBeVisible();
// The inline error is how users learn why a deploy failed, so it must
// carry docker's reason, not only "compose up: exit status 1".
expect(failed.error).toContain('127.0.0.1:1/e2e/missing');
// carry docker's reason, not only "compose up: exit status 1". Docker
// versions word it differently; all name the unreachable registry.
expect(failed.error).not.toMatch(/^compose up: exit status \d+$/);
expect(failed.error).toContain('127.0.0.1:1');
} finally {
expect((await apiRequest('DELETE', `/api/apps/${slug}`)).status).toBe(200);
}
Expand Down
Loading