Repository navigation
test(e2e): match the failed-deploy reason across Docker versions - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main E2E run 38161073546: 124/125 passed. The failed-deploy test checked the error for the image path, but the Linux Docker daemon on CI words it as
Get "http://127.0.0.1:1/v2/": dial tcp 127.0.0.1:1: connect: connection refused(no image path). The product behavior is right: the reason is shown (#128). The test now requires docker's reason (not the bareexit status) and the unreachable registry address, which every Docker version includes. Local 01+03+20: 15/15.