Repository navigation
Extract shared typing comparison helpers - #240
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
krzema12
force-pushed
the
refactor-typing-comparison
branch
from
November 21, 2026 13:36
32ae653 to
ff81ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Preliminary refactoring for the typing mismatch baseline work (stacked under #239).
Moves the inference/actual-typing comparison in
validateTypings()intocompareTypings(), which returns structuredTypingInferencerecords. Validation still prints exactly the same warning lines and compares actual vs inferred typings inline — no behavior change.Also extracts two small helpers:
Path.toActionCoords()for parsing the action path into coordinates, andMap<*, *>.names()for reading input/output names from a manifest or typings file.