Repository navigation
Conversation
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 13:01
7a0c7f6 to
0822173
Compare
krzema12
changed the base branch from
graphite-base/239
to
refactor-typing-comparison
November 21, 2026 13:01
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 13:07
0822173 to
36870a1
Compare
krzema12
force-pushed
the
refactor-typing-comparison
branch
from
November 21, 2026 13:36
32ae653 to
ff81ba5
Compare
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 13:36
36870a1 to
c3bf024
Compare
krzema12
added a commit
that referenced
this pull request
Nov 21, 2026
Preliminary refactoring for the typing mismatch baseline work (stacked under #239). Moves the inference/actual-typing comparison in `validateTypings()` into `compareTypings()`, which returns structured `TypingInference` records. Validation still prints exactly the same warning lines and compares actual vs inferred typings inline — no behavior change. Also extracts two small helpers: `Path.toActionCoords()` for parsing the action path into coordinates, and `Map<*, *>.names()` for reading input/output names from a manifest or typings file.
krzema12
force-pushed
the
typing-mismatch-baseline
branch
3 times, most recently
from
November 21, 2026 18:39
d1fa41c to
239bfe6
Compare
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 18:50
89e97ae to
8e13756
Compare
krzema12
force-pushed
the
graphite-base/239
branch
from
November 21, 2026 18:50
9ff5b39 to
04e5784
Compare
krzema12
changed the base branch from
graphite-base/239
to
graphite-base-ref-workaround
November 21, 2026 18:51
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 18:53
f3434a9 to
f6891f0
Compare
krzema12
force-pushed
the
graphite-base-ref-workaround
branch
from
November 21, 2026 18:53
e9b46a4 to
19f4b62
Compare
krzema12
added a commit
that referenced
this pull request
Nov 21, 2026
Graphite reports a synthetic `graphite-base/<PR>` branch as `github.base_ref` for stacked PRs. That branch does not exist on the remote, so `Validate typings` fails when it tries to fetch it to detect changed actions. This PR resolves the real base branch through the GitHub API whenever `github.base_ref` has the `graphite-base/` prefix. It is split out from #239 so the baseline change stays focused.
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 18:54
f6891f0 to
9553d56
Compare
krzema12
force-pushed
the
typing-mismatch-baseline
branch
from
November 21, 2026 19:00
9553d56 to
6940e45
Compare
krzema12
changed the base branch from
graphite-base/239
to
collect-validation-errors
November 21, 2026 19:00
krzema12
added a commit
that referenced
this pull request
Nov 21, 2026
Refactors `validateTypings()` so action-level validation problems (lowercase names, schema issues, missing manifests, input/output mismatches) are collected into a list instead of being printed and failed on immediately. At the end of the run all issues are printed together, sorted, with the affected action included in each message. No behavior change: the same conditions still fail validation. Split out of #239 to keep the baseline change focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #244.
Adds
typing-mismatches.yml: a checked-in baseline of every case where a typing in this catalog differs from the type inferred byTypingHeuristics(1,655 entries initially).Regenerate it with:
compareTypings()is the single source of truth used by both the dump and typing validation, so the baseline cannot drift from what CI checks.CI fails on all baseline inconsistencies for the validated actions: a missing mismatch, a stale entry where the heuristic now returns the actual type, or an entry with outdated actual/inferred typings. All issues across all actions and inputs are collected into the validation error report from #244, so the run reports everything at once.
PRs keep validating only changed typings;
mainand the nightly run validate the whole catalog. Only.ymlfiles are stored, with no heuristicreason/descriptiontext, so explanatory wording changes don't churn the baseline.