Repository navigation
fix(windows): avoid white startup flash after installing Taskly - #26
Merged
Merged
Conversation
2 of 5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MSI finish page offers Launch Taskly. On selecting it, the WinUI 3 window can appear in the default system-light/English presentation before the Racket backend has started and returned persisted preferences. This produces a jarring white flash for users who configured Taskly's dark theme, especially noticeable immediately after installation. The root Grid also lacks an explicit theme-aware background, leaving transparent areas to the window's default fill.
Changes
languageandthemefrom~/.taskly/config.inibeforeWindow.Activate(), respecting the WindowsUSERPROFILE → HOMEprecedence, comments, whitespace, case-insensitive keys, last-key-wins and documented fallbacks.get_settingsRPC remains authoritative and still refreshes the UI after backend startup.RootGridaThemeResource TasklySurfaceBrushbackground so the full client area paints consistently in dark and light mode.Verification
main.Scope note: This removes Taskly's launch-time white flash; the stock WiX MSI wizard's native white checkbox/license controls belong to Rivet's upstream installer UI and are not restyled by this PR. A separate upstream change would be needed if those controls themselves are the white areas being reported.
Does not merge automatically.