Repository navigation
fix(windows): eliminate the white patch behind MSI launch checkbox - #30
Open
turinglambdaai wants to merge 1 commit into
Open
turinglambdaai wants to merge 1 commit into
turinglambdaai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The stock WiX 5
WixUI_InstallDirExitDialog uses an opaque native Win32OptionalCheckBoxon the finish page. Taskly currently paints a full-size pastel gradient behind it, which creates an ugly rectangular, light-gray/white patch around “Launch taskly” when MSI draws the checkbox and its label. It is an installer UI problem, independent of the Taskly WinUI startup flash handled by #26.The stock layout positions the optional checkbox at
X=135, Y=190, Width=220, Height=40in a370×234dialog-bitmap area (WiX source tagv5.0.2). Taskly's bitmap is 493×312, so the checkbox overlaps approximatelyx=180–473, y=253–307.Fix
assets/wizard-dialog.bmpwith a quiet #F0F0F0 classic Windows control-face footer, starting at y=248 with a subtle divider at y=247. This blends the launch checkbox into a consistent surface and leaves the existing artwork and brand wordmark intact.Why not replace the checkbox with a fake transparent label?
Windows Installer checkboxes are opaque; splitting a native checkbox into a tiny clickable square plus a transparent Text control makes the label non-clickable and breaks accessibility (screen reader label association). This fix keeps the full real checkbox and its keyboard/screen-reader behavior.
Validation
ExitDialogcontrol coordinates and corresponding scaled BMP pixel positions.Scope: This PR fixes the native MSI checkbox backdrop, not the application window startup (#26). Standalone Taskly fix without an upstream Rivet dependency bump. No auto-merge.