Repository navigation
fix(core): serve a connection that arrives while the listeners are paused, and count the accepts the cap refuses (#359) - #360
Merged
Conversation
…used, and count the accepts the cap refuses (#359)
EdmondDantes
marked this pull request as ready for review
September 30, 2026 12:35
Contributor
CoverageTotal lines: 83.75% → 83.79% (+0.04 pp)
|
…4 before it merges
…php-async main again (#359)
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359. Needs true-async/php-async#306 merged first: this repository's CI builds php-async
main, whereh1/062–064read 503, so the PR stays a draft until then.h1/062: a third client during a pause atsetMaxConnections(2).h1/063: three connections at once past a cap of two.h1/064:setMaxConnections(1), a resume that pauses again while delivering.mainand passes 10 of 10 with fix(websocket): drain before closing an overflowed peer #306.getTelemetry()/getStats():accepts_refused_at_cap_total: the hard-cap safety net's 503s; a pause that holds keeps it at 0, and 062–064 assert that.accept_errors_total: accept failures that were dropped silently.telemetry/009lists both.http_server_pause_listenerssaid the REUSEPORT hash excludes a paused worker. It does not: the kernel keeps sending that worker its share, which waits for it.dev/PLAN.md. The design (pause by not accepting, over auv_pollloop) went through a Critic and a Sage, and the php-async diff through a Critic.