Repository navigation
asynctest: dispose a finished write and submit the next one inside its notify - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cmocka case for true-async/php-async#310: a listener on a pipe handle disposes the finished write request inside the completion notify and submits the next write there, as true-async-server's log sink does. The next request is allocated at the address just freed; the case checks that both writes complete and both payloads reach the peer. It skips itself when the allocator does not reuse the address, since the defect then has nothing to corrupt.
Evidence: SIGSEGV 3 of 3 against php-async
ef85610; passes 3 of 3, not skipped, with true-async/php-async#311. Merge after php#311, or php-async's CI goes red on it.