Repository navigation
ci: build the HTTP server test hooks on the Linux debug leg - #379
Merged
Merged
Conversation
…ooks # Conflicts: # dev/PLAN.md
Contributor
CoverageTotal lines: 83.95% → 84.00% (+0.05 pp)
|
…ooks # Conflicts: # dev/PLAN.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux debug leg configures with
--enable-http-server-test-hooks, so the 20 phpt gated on the_http_*functions run in CI: the log sink tests incore/(019, 020, 022, 024, 026, 030, 031, 056),reactor_pool/001to010, andtelemetry/001to003. Nothing ran them before.Merge after true-async/php-async#311. Built with the flag,
core/030crashed with SIGSEGV on every run (3 of 3 under run-tests): php-async'sio_pipe_write_cbclearedioon a write request the log sink had already freed inside the completion notify, and the next write took its address (true-async/php-async#310; asynctest case true-async/php-src#39). With #311, the 20, the four tests behind--enable-tas-test-hooksand the rest ofreactor_pool/pass 35 of 35, 3 runs of 3.Also closes plan item 16 (#348, done in PR 349) in
dev/PLAN.md.