Skip to content

docs: clarify inherited local safety matcher limits #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 2 commits into from
Oct 11, 2026
Merged

docs: clarify inherited local safety matcher limits #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f469d
docs(safety): document inherited safety limitations
senamakel Oct 11, 2026
3e671af
Merge remote-tracking branch 'origin/main' into shrink-core-utilities…
senamakel Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/tinymemory-api/src/safety/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,14 @@ consumers own diagnostics and must consider the sensitivity of derived categorie

Risk vocabulary is available by default. Enable `local-safety` for regex-based
classification and redaction; the default engine contract stays regex-free.


Known inherited limitations remain unchanged by this ownership move: grouped
IBANs can be missed ([260](https://github.com/tinyhumansai/tinymemory/issues/260)),
overlapping phone rules can count one number twice
([261](https://github.com/tinyhumansai/tinymemory/issues/261)), and card boundaries
or an adjacent CVV can produce incomplete matching
([262](https://github.com/tinyhumansai/tinymemory/issues/262)). The international
phone repetition counts separators rather than normalized digits, so seven-digit
numbers can be missed and longer or separator-heavy strings accepted
([263](https://github.com/tinyhumansai/tinymemory/issues/263)).
3 changes: 2 additions & 1 deletion crates/tinymemory-api/src/safety/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ fn build_rules() -> Vec<Rule> {
r"\b(?:\+?1[-.\s]?)?\(?\d{3}\)?[-.\s]\d{3}[-.\s]\d{4}\b",
None,
),
// International E.164-ish phone number (leading + and 7–15 digits).
// Legacy international phone-like pattern. Its repetition counts
// separators too; normalized digit bounds remain follow-up #263.
pattern_rule(PiiCategory::PhoneNumber, r"\+\d(?:[\d\s\-]{6,16}\d)", None),
// IPv4 address (octet-validated).
pattern_rule(
Expand Down
Loading