Repository navigation
docs: clarify inherited local safety matcher limits - #264
Conversation
The safety README now records the known inherited limitations that remain unchanged by the ownership move, covering grouped IBANs, overlapping phone rules, card boundaries, and international phone repetition. The international phone rule comment was also updated to note that its repetition counts separators rather than normalized digits, with the digit bounds tracked as follow-up #263. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This documentation change accurately describes existing detector limitations without changing detection behavior; no merge-blocking risk was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: documentation that clarifies inherited local safety matcher limitations.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit reads the safety page
Four limits hop onto the stage
The phone rule’s comment now is clear
Its pattern stays as it was here
No regex changed along the way
The rabbit thumps a brief hooray
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Tiny Sweeper review
Previous completed reportTiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["build_rules<br/>changed"]:::changed
n1["Rule"]:::impacted
n2["PiiCategory"]:::impacted
n3["compile_builtin"]:::impacted
n4["keyword_rule"]:::impacted
n5["pattern_rule"]:::impacted
n6["rules"]:::impacted
n0 -->|uses| n1
n1 -->|uses| n2
n4 -->|uses| n1
n4 -->|uses| n2
n4 -->|calls| n3
n5 -->|uses| n1
n5 -->|uses| n2
n5 -->|calls| n3
n6 -->|uses| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0002 · 104,099 in / 1,895 out · 29,952 cached (29%) · ladder/vectors-oai3, deepseek-v4.1-flash · 119 embedded
critique: $0.0000 · 45,887 in / 517 out · 7,552 cached (16%) · deepseek-v4.1-flash
security: $0.0000 · 14,337 in / 96 out · 2,944 cached (21%) · deepseek-v4.1-flash
tests: $0.0000 · 30,489 in / 328 out · 15,360 cached (50%) · deepseek-v4.1-flash
description: $0.0000 · 11,454 in / 297 out · 4,096 cached (36%) · deepseek-v4.1-flash
tinysweeper
Bot
added
the
priority: p3
1 participant
Document the inherited IBAN, phone, PAN/CVV, and international-phone matcher limits with actionable follow-up links (#260, #261, #262, #263). Correct the phone rule comment to describe its separator-inclusive quantifier. Detection and redaction behavior remain unchanged. Follow-up to #259.
Validation: tinymemory-api formatting and strict all-feature API documentation passed.
Summary by CodeRabbit