Skip to content

fix: quote path when detecting min-required versions #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vulragrag-star wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: quote path when detecting min-required versions #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/tfenv-min-required.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ set -uo pipefail;
function tfenv-min-required() {
local path="${1:-${TFENV_DIR:-.}}";

local versions="$( echo $(cat ${path}/{*.tf,*.tf.json} 2>/dev/null | grep -Eh '^\s*[^#]*\s*required_version') | grep -o '[~=!<>]\{0,2\}\s*\([0-9]\+\.\?\)\{2,3\}\(-[a-z]\+[0-9]\+\)\?')";
local versions="$( echo $(cat "${path}"/{*.tf,*.tf.json} 2>/dev/null | grep -Eh '^\s*[^#]*\s*required_version') | grep -o '[~=!<>]\{0,2\}\s*\([0-9]\+\.\?\)\{2,3\}\(-[a-z]\+[0-9]\+\)\?')";

if [[ "${versions}" =~ ([~=!<>]{0,2}[[:blank:]]*)([0-9]+[0-9.]+)[^0-9]*(-[a-z]+[0-9]+)? ]]; then
qualifier="${BASH_REMATCH[1]}";
found_min_required="${BASH_REMATCH[2]}${BASH_REMATCH[3]}";
if [[ "${qualifier}" =~ ^!= ]]; then
log 'debug' "required_version is a negation - we cannot guess the desired one, skipping.";
else
local min_required_file="$(grep -Hn required_version ${path}/{*.tf,*.tf.json} 2>/dev/null | xargs)";
local min_required_file="$(grep -Hn required_version "${path}"/{*.tf,*.tf.json} 2>/dev/null | xargs)";

# Probably not an advisable way to choose a terraform version,
# but this is the way this functionality works in terraform:
Expand Down
25 changes: 25 additions & 0 deletions test/test_use_minrequired.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,31 @@ echo 'min-required' > chdir-dir/.terraform-version

cleanup || log 'error' 'Cleanup failed?!';


log 'info' '### Detect min-required when working directory path contains spaces (#537)';

spaced_dir="${PWD}/project with spaces";
mkdir -p "${spaced_dir}";
minv='1.6.0';
echo "terraform {
required_version = \">=${minv}\"
}" > "${spaced_dir}/versions.tf";

(
cd "${spaced_dir}" || exit 1;
# bin/tfenv exports TFENV_DIR="${PWD}" before dispatching. Paths with spaces
# used to break unquoted ${path}/{*.tf,*.tf.json} globs in tfenv-min-required,
# so install/resolve-version min-required failed with an empty version.
export TFENV_DIR="${PWD}";
detected="$(tfenv min-required)" || exit 1;
[ "${detected}" = "${minv}" ] || exit 1;
resolved="$(tfenv-resolve-version min-required)" || exit 1;
[ "${resolved}" = "${minv}:^${minv}$" ] || exit 1;
) || error_and_proceed 'Min-required detection failed when path contains spaces';

rm -rf "${spaced_dir}";
cleanup || log 'error' 'Cleanup failed?!';

finish_tests 'use_minrequired';

exit 0;