fix: quote path when detecting min-required versions - #540
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Unquoted ${path}/{*.tf,*.tf.json} word-splits when TFENV_DIR or the
working directory contains spaces, so min-required resolution finds no
files and install/resolve fails. Quote the path in both globs and add a
regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tfenv install min-required(andtfenv min-required/ resolve-version) fails when the working directory path contains spaces (e.g.~/My Drive/project).bin/tfenvexportsTFENV_DIR="${PWD}"before dispatching. Inlib/tfenv-min-required.sh,${path}was unquoted in the{*.tf,*.tf.json}globs, so bash word-split the path, no files were read, and version resolution came back empty.This quotes
"${path}"in both globs so spaced directories resolve correctly.Issue Link
Closes #537
Testing
tfenv min-requiredin a directory whose path contains spaces → error / empty version1.6.0andtfenv-resolve-version min-required→1.6.0:^1.6.0$test/test_use_minrequired.sh(spaces path; no network install required for that case)./test/run.shnot run here (other cases need Terraform downloads)Platform tested: Linux (box)
Quality Checklist
{}globs unchanged otherwise