Repository navigation
Conversation
20ab546 to
ecbaf88
Compare
|
Add screenshots to the pull request description to illustrate your work, as @ColtenOuO suggests. Example: #349 |
ecbaf88 to
ffa5f00
Compare
|
The
Each refusal and its fix: https://github.com/sysprog21/codetrial/blob/main/docs/large-change-explanation.md#troubleshooting |
ffa5f00 to
1884697
Compare
1884697 to
9650d18
Compare
| } | ||
|
|
||
| .session-panel .setup-heading > div { | ||
| padding-right: 4.5rem; |
There was a problem hiding this comment.
This padding is what fails the two one-screen lobby tests in gates (browser 1/3) (body height 811 against 800): at 1280x800 the session column is 373px wide, so it wraps "Set up your session" onto a second line, and the taller heading grows the whole setup row and pushes the footer off screen. Dropping it alone restores 800, but then the title runs under the "Saved setups" button, which is 133px wide, so 72px of padding never cleared it anyway. Move the trigger out of the heading row to a place that takes no new line at this width, for example beside the Session length label.
There was a problem hiding this comment.
現在「Session length」和「Saved setups」已放進 .session-length-heading 所以元素都移到上方,所以子元素的 margin 要清掉
把position從absolute改成flex 讓Session length和Saved setups可以正常排列
確保標題不會被按鈕蓋住
把css 裡的檔案改成
.session-length-heading {
display: flex;
align-items: baseline;
justify-content: space-between;
gap: 0.75rem;
margin-top: 1.25rem;
}
.session-length-heading .setting-label,
.session-presets-trigger {
margin: 0;
}
jserv
left a comment
There was a problem hiding this comment.
Rebase the current branch onto the upstream default branch and resolve any conflicts. Run /codetrial-review in AI agents (use $codetrial-review in Codex) and resolve all identified issues. Rework the series into minimal, logically coherent commits, squash closely related commits, and ensure all commit messages follow the project’s rules.
|
Some review comments on this pull request are not settled yet. Please refine the change per the review comments listed below, reply on each thread with what you changed or why you did not, and mark each thread resolved yourself once it is settled (Resolve conversation, at the bottom of the thread). The pull request stays blocked while review threads are open. Not addressed at the current head:
Addressed at the current head; reply with what changed and resolve:
Checked at 9650d18. |
Candidates who switch between practice formats currently have to reconfigure the lobby each time. Preserve multiple browser-local setups and restore them without changing the selected problem, difficulty filters, or optional interview context. Cover saving, updating, deleting, reloading, and compatibility with controls added after a setup was saved. Close sysprog21#591 Change-Id: I40d4cc78525d421b4bbdf26b343e54266cf4b48d
9650d18 to
655afd9
Compare
Problem and behavior
Candidates who switch between practice formats currently have to reconfigure
the lobby each time because CodeTrial preserves only the most recently used
settings.
This change lets candidates save multiple browser-local session setups under
different names. Selecting a saved setup immediately restores its session
length, interview format, and editor options without changing the selected
problem, difficulty filters, or optional interview context.
Candidates can also update an existing setup by saving under the same name and
delete setups they no longer need. Saved setups remain available after
reloading the lobby.
Approach
Store all named setups as individual records under one local storage key.
The implementation reuses
selectedEditorOptionsandsaveEditorOptionsinstead of maintaining a separate editor-option list. Missing fields are left
unchanged when applying an older setup, while fields unknown to the current
version are preserved when records are rewritten.
Save and delete operations re-read storage inside a Web Lock so simultaneous
changes from different lobby tabs do not overwrite each other.
At the time this pull request was opened, #584 and #590 were still open and
were therefore not included. If a saved setup does not contain a control added
later, applying it keeps that control's current value.
Screenshots
Lobby
Save setups
Select setups
Validation
node --test tests/browser/lobby.test.js: 281 tests passed.lobby from working.
fields added by newer versions.
below the offered durations.
git diff --check.Close #591
Summary by cubic
Lets candidates save named session setups in their browser and restore them later, instead of reconfiguring session length, interview format, and editor options each time.
Written for commit 655afd9. Summary will update on new commits.