Skip to content

Delete superseded refine reminders in the PR sweep - #639

Merged
jserv merged 1 commit into
mainfrom
refine-reminder-dedupe
Nov 9, 2026
Merged

jserv merged 1 commit into
mainfrom
refine-reminder-dedupe

Conversation

@jserv

@jserv jserv commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

The PR sweep left several "Some review comments on this pull request are not settled yet" reminders on a PR that still had open threads (#561 carried four). Only the review that posts a new reminder deleted the older ones, and the sweep deleted reminders only once every thread was resolved, so copies posted before that cleanup existed stayed forever. The sweep now lists every viewer reminder but the newest as superseded, and apply-pr-actions.sh re-reads the PR's live comments before deleting one: a copy that is already gone is reported as already done, and one that has become the only reminder is kept.

Verified with python3 -m unittest tests.test_skill_scripts (229 tests, new cases for ordering by time, a single reminder, another author's comment, the 100-comment window, and a refused delete), shellcheck, ruff and scripts/check-skill-refs.py. Run live on the repository, the refined sweep found and deleted five leftover reminders (#110, #295 twice, #584, #597). Codex, Agy and a Claude reviewer found no blocking issue; their findings on the live re-check, ordering and the comment window are fixed here.

Not changed: a PR with more than 100 comments still gets no cleanup, as before, and the three places that match "the viewer's reminder" (the sweep, the apply step and review-finish.sh) still spell the match separately.


Summary by cubic

Fixes leftover "Some review comments on this pull request are not settled yet" reminders stacking up on PRs that still have open threads.

The PR sweep now marks every refine reminder but the newest as superseded and deletes the superseded ones, while apply-pr-actions.sh re-reads the PR's live comments for each row so a concurrent review can't leave the PR with no current reminder. Copies that are already gone or have become the newest are reported or kept without error.

  • Adds why: to refine_stale entries to distinguish superseded from settled deletions.
  • Adds unit tests covering ordering by time, a single reminder, other authors' comments, the 100-comment window, and refused deletes.
  • On PRs with more than 100 comments or threads, cleanup is still skipped as before.

Written for commit 3c8e551. Summary will update on new commits.

View guided diff Turn on auto-fix

@jserv
jserv requested a review from ColtenOuO as a code owner November 9, 2026 20:20
cubic-dev-ai[bot]

This comment was marked as resolved.

A PR with open threads kept every earlier "not settled yet" reminder,
because only the review that posts a new one trimmed the old copies and
the sweep deleted them only once every thread was resolved. #561 showed
four. The sweep now lists every copy but the newest as superseded, and
apply-pr-actions.sh re-reads the live comments for each row before
deleting one, so a concurrent review cannot leave the PR with none. The
trim covers only PRs within 100 comments and 100 threads.

Change-Id: Ib9c31f785a541290fe5094aeea21b21da736ea96
@jserv
jserv force-pushed the refine-reminder-dedupe branch from 58542f2 to 3c8e551 Compare November 9, 2026 20:42
@jserv
jserv merged commit 0406460 into main Nov 9, 2026
15 checks passed
@jserv
jserv deleted the refine-reminder-dedupe branch November 9, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant