Repository navigation
Conversation
1 task
pwltr
marked this pull request as ready for review
October 6, 2026 13:40
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: synonymdev/bitkit-ios#485
Companion: iOS #879.
This PR preserves an outgoing RBF replacement's selected fee rate when activity arrives or is refreshed, so consumer apps can show the correct confirmation estimate.
Description
Out of Scope
Preview
N/A — shared persistence APIs; no UI changes.
QA Notes
Manual Tests
The author verified the fix in the iOS simulator using a local SDK built on the apps' existing 0.5.18-compatible base. The draft is rebased onto current core master; the activity implementation and tests are identical to that tested snapshot. Integration with the full current-master SDK must be checked when publishing/updating the consumer dependency.
Automated Checks
rbf_tests.rs— ten regressions cover replacement arrival order, persistence across database reopen, stale snapshots, wallet isolation, invalid inputs, metadata preservation, and atomic rollback/retry.