Repository navigation
Conversation
1 task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: iOS #485.
This PR preserves outgoing RBF boost fee rates during activity sync so replacement transactions retain the correct confirmation estimate.
Depends on bitkit-core #166. Companion: iOS #879.
Draft dependency gate: the published 0.5.18 SDK does not expose the two new core APIs. Before merging, publish the core fix, update the Android dependency to that release, and rerun integration checks against the released SDK. Current core master includes changes beyond 0.5.18 that must be accounted for during the upgrade. The temporary local SDK build and dependency substitution are deliberately excluded from this PR.
Description
Out of Scope
Design
N/A — no UI changes.
Preview
before.mov
Screen.Recording.2026-10-06.at.17.44.28.mov
QA Notes
Journeys
rbf-replacement-fee-rate.xml— verifies a low-fee outgoing transaction's replacement shows the boosted confirmation estimate, retains its real total fee after sync/reopening, and confirms normally.The author reproduced the original issue on Android master and manually verified the RBF fix using the local ARM64 core SDK built on a 0.5.18-compatible snapshot. The same fix has been manually verified on iOS; iOS tag/contact carryover and ordinary send/receive checks also passed. The full shared journey remains listed for reviewer execution against the final released SDK.
Manual Tests
N/A
Automated Checks
ActivityServiceRbfTest.kt— verifies the atomic core recording API and fee-preserving payment sync, reorg, and eviction updates.ActivityRepoTest.kt— verifies wallet scoping, activity/tag notifications, storage failure propagation, and cancellation.BoostTransactionViewModelTest.kt— verifies successful and failed RBF boosts, capturing the submitted rate, and preserving broadcast success after a storage failure; existing CPFP coverage remains passing.