Skip to content

test: migrate blas/base/scasum to ULP-based assertions #16325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Oct 29, 2026
Merged

test: migrate blas/base/scasum to ULP-based assertions #16325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e3c515
test: migrate `blas/base/scasum` to ULP-based assertions
claude Oct 27, 2026
04afec2
Merge branch 'develop' into philipp/ulp-blas-base-scasum
kgryte Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 6 additions & 32 deletions lib/node_modules/@stdlib/blas/base/scasum/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,36 +22,10 @@

var tape = require( 'tape' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var scasum = require( './../lib/ndarray.js' );


// FUNCTIONS //

/**
* Tests for element-wise approximate equality.
*
* @private
* @param {Object} t - test object
* @param {number} actual - actual value
* @param {number} expected - expected value
* @param {number} rtol - relative tolerance
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;

if ( actual === expected ) {
t.strictEqual( actual, expected, 'returns expected value' );
} else {
delta = abs( actual - expected );
tol = rtol * EPS * abs( expected );
t.ok( delta <= tol, 'within tolerance. actual: '+actual+'. expected: '+expected+'. delta: '+delta+'. tol: '+tol+'.' );
}
}


// TESTS //

tape( 'main export is a function', function test( t ) {
Expand Down Expand Up @@ -85,7 +59,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.6;

actual = scasum( 4, x, 1, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );

x = new Complex64Array([
0.1, // 1
Expand All @@ -100,7 +74,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.3;

actual = scasum( 3, x, 1, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -160,7 +134,7 @@ tape( 'the function supports specifying a stride', function test( t ) {
expected = 1.6;

actual = scasum( 4, x, 2, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -190,7 +164,7 @@ tape( 'the function supports specifying a negative stride', function test( t ) {
expected = 28.9;

actual = scasum( 4, x, -1, 3 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -244,6 +218,6 @@ tape( 'the function supports specifying complex access patterns', function test(
expected = 1.6;

actual = scasum( 4, x, -2, 6 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});
38 changes: 6 additions & 32 deletions lib/node_modules/@stdlib/blas/base/scasum/test/test.ndarray.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand All @@ -36,31 +35,6 @@ var opts = {
};


// FUNCTIONS //

/**
* Tests for element-wise approximate equality.
*
* @private
* @param {Object} t - test object
* @param {number} actual - actual value
* @param {number} expected - expected value
* @param {number} rtol - relative tolerance
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;

if ( actual === expected ) {
t.strictEqual( actual, expected, 'returns expected value' );
} else {
delta = abs( actual - expected );
tol = rtol * EPS * abs( expected );
t.ok( delta <= tol, 'within tolerance. actual: '+actual+'. expected: '+expected+'. delta: '+delta+'. tol: '+tol+'.' );
}
}


// TESTS //

tape( 'main export is a function', opts, function test( t ) {
Expand Down Expand Up @@ -94,7 +68,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.6;

actual = scasum( 4, x, 1, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );

x = new Complex64Array([
0.1, // 1
Expand All @@ -109,7 +83,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.3;

actual = scasum( 3, x, 1, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -169,7 +143,7 @@ tape( 'the function supports specifying a stride', opts, function test( t ) {
expected = 1.6;

actual = scasum( 4, x, 2, 0 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -199,7 +173,7 @@ tape( 'the function supports specifying a negative stride', opts, function test(
expected = 28.9;

actual = scasum( 4, x, -1, 3 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -253,6 +227,6 @@ tape( 'the function supports specifying complex access patterns', opts, function
expected = 1.6;

actual = scasum( 4, x, -2, 6 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});
36 changes: 5 additions & 31 deletions lib/node_modules/@stdlib/blas/base/scasum/test/test.scasum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,36 +22,10 @@

var tape = require( 'tape' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var scasum = require( './../lib/scasum.js' );


// FUNCTIONS //

/**
* Tests for element-wise approximate equality.
*
* @private
* @param {Object} t - test object
* @param {number} actual - actual value
* @param {number} expected - expected value
* @param {number} rtol - relative tolerance
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;

if ( actual === expected ) {
t.strictEqual( actual, expected, 'returns expected value' );
} else {
delta = abs( actual - expected );
tol = rtol * EPS * abs( expected );
t.ok( delta <= tol, 'within tolerance. actual: '+actual+'. expected: '+expected+'. delta: '+delta+'. tol: '+tol+'.' );
}
}


// TESTS //

tape( 'main export is a function', function test( t ) {
Expand Down Expand Up @@ -85,7 +59,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.6;

actual = scasum( 4, x, 1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );

x = new Complex64Array([
0.1, // 1
Expand All @@ -100,7 +74,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.3;

actual = scasum( 3, x, 1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -160,7 +134,7 @@ tape( 'the function supports specifying a stride', function test( t ) {
expected = 1.6;

actual = scasum( 4, x, 2 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand All @@ -182,7 +156,7 @@ tape( 'the function supports specifying a negative stride', function test( t ) {
expected = 28.9;

actual = scasum( 4, x, -1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down
36 changes: 5 additions & 31 deletions lib/node_modules/@stdlib/blas/base/scasum/test/test.scasum.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var Complex64Array = require( '@stdlib/array/complex64' );
var EPS = require( '@stdlib/constants/float32/eps' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand All @@ -36,31 +35,6 @@ var opts = {
};


// FUNCTIONS //

/**
* Tests for element-wise approximate equality.
*
* @private
* @param {Object} t - test object
* @param {number} actual - actual value
* @param {number} expected - expected value
* @param {number} rtol - relative tolerance
*/
function isApprox( t, actual, expected, rtol ) {
var delta;
var tol;

if ( actual === expected ) {
t.strictEqual( actual, expected, 'returns expected value' );
} else {
delta = abs( actual - expected );
tol = rtol * EPS * abs( expected );
t.ok( delta <= tol, 'within tolerance. actual: '+actual+'. expected: '+expected+'. delta: '+delta+'. tol: '+tol+'.' );
}
}


// TESTS //

tape( 'main export is a function', opts, function test( t ) {
Expand Down Expand Up @@ -94,7 +68,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.6;

actual = scasum( 4, x, 1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );

x = new Complex64Array([
0.1, // 1
Expand All @@ -109,7 +83,7 @@ tape( 'the function computes the sum of the absolute values of the real and imag
expected = 1.3;

actual = scasum( 3, x, 1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down Expand Up @@ -169,7 +143,7 @@ tape( 'the function supports specifying a stride', opts, function test( t ) {
expected = 1.6;

actual = scasum( 4, x, 2 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand All @@ -191,7 +165,7 @@ tape( 'the function supports specifying a negative stride', opts, function test(
expected = 28.9;

actual = scasum( 4, x, -1 );
isApprox( t, actual, expected, 2.0 );
t.strictEqual( isAlmostSameValuef( actual, expected, 1 ), true, 'returns expected value' );
t.end();
});

Expand Down
Loading