Repository navigation
test: migrate blas/base/scasum to ULP-based assertions - #16325
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD7Atvdz918auatthNRx
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
blas/base/scasum(test.scasum.js,test.ndarray.jsand their.native.jscounterparts) from theEPS/relative-toleranceisApproxhelper toisAlmostSameValueffrom@stdlib/number/float32/base/assert/is-almost-same-value.1(all fixtures in all four files). Measured minimum:0fails,1passes at every call site (checked per call site againsttest.scasum.jsandtest.ndarray.js; two consecutive runs gave identical results). The.native.jsfiles use the same value but were skipped locally because the native addon is not built in this environment.EPS/absrequires and theisApproxhelper.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Reference Packages
This pull request followed these packages:
blas/base/snrm2t.strictEqual( isAlmostSameValuef( actual, expected, N ), true, 'returns expected value' )) and removal of theisApproxhelper.Questions
No.
Other
Native tests were not run (addon unavailable); please confirm in CI. Pre-commit hooks could not run locally (incomplete
node_modules);eslintwas run manually on the test directory and was clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as an automated scheduled routine.
@stdlib-js/reviewers
Generated by Claude Code