Skip to content

test: migrate math/base/special/binomcoeff to ULP-based assertions #14572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Aug 25, 2026
+2 −11
Merged

test: migrate math/base/special/binomcoeff to ULP-based assertions #14572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions lib/node_modules/@stdlib/math/base/special/binomcoeff/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var absf = require( '@stdlib/math/base/special/absf' );
var EPS = require( '@stdlib/constants/float32/eps' );
var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var tryRequire = require( '@stdlib/utils/try-require' );

Expand Down Expand Up @@ -52,8 +51,6 @@ tape( 'main export is a function', opts, function test( t ) {

tape( 'the function evaluates the binomial coefficient for integers `n` and `k`', opts, function test( t ) {
var expected;
var delta;
var tol;
var n;
var k;
var v;
Expand All @@ -65,15 +62,9 @@ tape( 'the function evaluates the binomial coefficient for integers `n` and `k`'
for ( i = 0; i < n.length; i++ ) {
v = binomcoeff( n[ i ], k[ i ] );
expected[ i ] = float64ToFloat32( expected[ i ] );
if ( expected[ i ] === v ) {
t.strictEqual( v, expected[ i ], 'returns expected value' );
continue;
}
delta = absf( v - expected[ i ] );

// NOTE: Exact comparison fails for large values due to single-precision floating-point rounding errors when intermediate results exceed the maximum safe integer for a 32-bit float.
tol = 1.25 * EPS * absf( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. n: ' + n[ i ] + '. k: ' + k[ i ] + '. actual: ' + v + '. expected: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 2 ), true, 'returns expected value' );
}
t.end();
});
Expand Down