test: migrate math/base/special/binomcoeff to ULP-based assertions - #14572
Draft
Planeshifter wants to merge 1 commit into
Draft
test: migrate math/base/special/binomcoeff to ULP-based assertions#14572Planeshifter wants to merge 1 commit into
math/base/special/binomcoeff to ULP-based assertions#14572Planeshifter wants to merge 1 commit into
Conversation
…assertions Replaces the manual delta/tolerance comparison in test.native.js with isAlmostSameValue, mirroring the pattern already used in test.js for this package. The tightest ULP bound found is 2 (matches the JS binding's bound). Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Math
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11352.
Description
This pull request:
test/test.native.jsformath/base/special/binomcoefffrom a manualdelta/toltolerance comparison toisAlmostSameValue-based (ULP) assertions, mirroring the pattern already used intest/test.jsfor the same package2, matching the bound already established in the JS binding's tests (test/test.js)Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
test/test.jsfor this package was already converted to useisAlmostSameValuewithN=2; onlytest/test.native.jsstill used the old manual tolerance idiom. This PR bringstest/test.native.jsin line withtest/test.js. The minimum ULP bound was found by testingN=0(111 failures),N=1(3 failures), andN=2(0 failures, 2006/2006 passing), then confirmed deterministic by running the suite twice atN=2.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, running as a scheduled/automated task to migrate stdlib packages to ULP-based test assertions per #11352.
@stdlib-js/reviewers
Generated by Claude Code