Repository navigation
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
This was referenced Oct 23, 2026
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
erichare
force-pushed
the
fix/mcp-tool-argument-descriptions
branch
from
November 5, 2026 19:28
f3b0220 to
0cc5d9c
Compare
4 tasks done
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Gives every MCP tool argument a description that says what it is and what JSON it takes, to the standard #2619 set for findAndRerank. Aaron asked for this in review. Filter and sort keep their class descriptions, and arguments whose schema hides the wire shape end with an example. A contract test deserializes each example as its argument type.
Update arguments use the UpdateClause description from #2651 instead of repeating it.
Which issue(s) this PR fixes:
Addresses the MCP argument portion of #2604.
Verification
93 focused tests passed with 0 failures, 0 errors, and 0 skips at
0cc5d9c3f, this PR's commit in the rebuilt stack. The format check found 0 non-complying files out of 1,201. CI runs the unit and DSE/HCD integration suites on this push.Manual client checks were not run.
Checklist
MCP stack
Merges bottom up; row 1 is the bottom of the stack.