Skip to content

test: verify MCP request isolation and document tracing support - #2656

Open
erichare wants to merge 2 commits into
fix/mcp-command-validationfrom
fix/mcp-request-isolation
Open

erichare wants to merge 2 commits into
fix/mcp-command-validationfrom
fix/mcp-request-isolation

Conversation

@erichare

@erichare erichare commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Tests overlapping MCP calls completed in reverse order on one worker. The tests check separate request IDs and callbacks, worker context restoration, and cleanup when one command subscription is canceled. Trace metadata cannot authenticate a request and stays out of responses and logs.

Documents that the current build does not enable OpenTelemetry. Quarkiverse provides the integration, so this PR adds no runtime tracing code.

Which issue(s) this PR fixes:

Refs #2629. Enabling distributed tracing and defining allowed baggage keys and size limits remain open.

Verification

19 focused tests passed with 0 failures, 0 errors, and 0 skips at b07ca8d68, this PR's commit in the rebuilt stack. The format check found 0 non-complying files out of 1,217. The packaged MCP integration suite was not rerun locally after the rebuild. CI runs the unit and DSE/HCD integration suites on this push.

JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp com.spotify.fmt:fmt-maven-plugin:check test -DskipITs -Dxml-format.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dquarkus.http.test-port=19089 '-Dtest=McpLoggingTest,McpResourceTest'

HTTP disconnect cancellation, active distributed tracing, and manual client qualification remain unverified.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

MCP stack

Merges bottom up; row 1 is the bottom of the stack.

# PR Change Issue
1 #2651 Show accepted update syntax in tool schemas Fixes #2631
2 #2658 Describe every tool argument Part of #2604
3 #2645 Close the command context after each call Part of #2629
4 #2653 Return useful errors when setup fails Fixes #2628
5 #2648 Keep payloads and credentials out of logs Fixes #2635
6 #2649 Describe side effects and retry behavior Fixes #2636
7 #2655 Validate commands like the HTTP API Fixes #2632
8 #2656 Test request isolation, document tracing Refs #2629
9 #2657 Reject unapproved browser origins Part of #2630
10 #2659 Serve only protocol 2026-07-28 Part of #2625, #2626
11 #2669 Add opt-in OAuth authentication Refs #2642, #2643

@erichare
erichare requested a review from a team as a code owner October 22, 2026 20:09
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.98%
This PR 73.07%
Delta 🟢 +0.09%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 73.07% 🍏

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.33%
This PR 74.41%
Delta 🟢 +0.08%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.41% 🍏

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 56.74%
This PR 58.14%
Delta 🟢 +1.40%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 58.14% 🍏

There is no coverage information present for the Files changed

@erichare
erichare removed this pull request from stack #2660 October 27, 2026 23:11
@erichare
erichare added this pull request to stack #2667 October 27, 2026 23:12
@erichare
erichare force-pushed the fix/mcp-request-isolation branch from a270ca0 to fc71518 Compare October 27, 2026 23:54
@erichare
erichare force-pushed the fix/mcp-request-isolation branch from fc71518 to e2afa1f Compare October 27, 2026 23:59
@erichare
erichare added this pull request to stack #2672 November 5, 2026 19:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant