Repository navigation
Conversation
…ystem in the diagnostics creation order
|
📦 Development package |
|
✅ Development package validation passed on all platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623.
On the Raspberry Pi 5, V3DV can bin a draw before the uploads submitted ahead of it have finished, so geometry read from a buffer updated every frame has holes on the 64 px tile grid. This PR waits for the uploads there.
PixelyConfig.UploadWaitwithAutomatic(the default),OnandOff.PIXELY_UPLOAD_WAIToverrides it withautomatic,onoroff.GpuMemorySystem.Submit()submits the uploads withSDL_SubmitGPUCommandBufferAndAcquireFenceand waits on the fence. Render coordinators already submit the uploads before the frame, so the frame starts only after they finish. When the wait is off, the submit is unchanged.Automaticturns the wait on when the device's driver name (SDL_PROP_GPU_DEVICE_DRIVER_NAME_STRING) starts withV3DV. Mesa reports exactlyV3DV Mesa, with the version in a separate property.Automaticis off, andOnfails atBuild()withPixelyInitializationException, because the browser build cannot wait on a fence.GpuMemorySystemis now created byPixelyFactory, which reads the config. Its public constructor keeps the wait off.GPU device:line ends withupload wait onorupload wait off, read from theGpuMemorySystem.PixelyConfiggets a new last positional parameter, so code compiled against the old constructor orDeconstructmust be rebuilt.window-rendering.md(new section "Waiting for uploads"),diagnostics.md,headless.md,hosting.md, and aDECISIONS.mdentry.Verification
Pixely.Tests: 447 of 447 pass, including new tests for the resolver, the environment variable, the factory and the diagnostics line.on,offandautomaticrun, and the diagnostics line reportson,offandoff.grimmethod, unset andongive 0 frames with holes, andoffstill shows them.