Repository navigation
docs: let gap_satisfied cover the fleet search too - #1532
Merged
Merged
Conversation
Energyplan 0.5.0 returns gap_satisfied from its fleet search when the search stops on mip_rel_gap and the published gap still meets it. The contract said only the library could claim it. Name the search instead. Paired with the byte-identical copy in srcfl/energyplan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Paired Energyplan PR: https://github.com/srcfl/energyplan/pull/63 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Energyplan 0.5.0 returns
gap_satisfiedfrom its fleet search when the search stops onmip_rel_gapand the published gap still meets it. The contract said only the library could claim that status. This names the search instead. Core passes the status through and does not branch on it, so no code changes.Paired with srcfl/energyplan's byte-identical copy (link in the next comment). That PR also brings over the forecast-source lines from #1494, which never reached the Energyplan copy.
Docs only, so no changeset.
🤖 Generated with Claude Code