Repository navigation
chore(optimizer): bundle Energyplan 0.5.1 - #1535
Merged
Merged
Conversation
Bundle the worker built from srcfl/energyplan 36bd719 (0.5.1) for linux-arm64, linux-amd64 and darwin-arm64. Licenses, notices and forecast schemas are unchanged. Protocol v1 is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
FTW ships Energyplan 0.5.0. On the home box, plans with the car could cost up to about 10 kr more than the best plan within Core's 1.5 s car budget on a Raspberry Pi 4. The cause sat in the planner: once it had met the car's charging goals, a round-off in the goal search made it drop the step that plans the battery around that charging, so the plan kept a battery schedule chosen without regard to cost. A second check threw such plans away for a pricing difference that does not change the plan.
Energyplan 0.5.1 (private source, srcfl/energyplan #63–#72):
Protocol v1, signs and Core validation are unchanged. Core still validates every plan.
Evidence
Measured on a laptop on 228 recorded battery + car requests from the home box (26 Sep to 3 Oct), each against a reference optimum. On fleet requests the Pi 4 is 17–20 times slower than the laptop, so Core's 1.5 s is about 85 ms there.
Verification
make native-solver-testandmake verifypass on this commit.Checklist
optimizer/nativeor the two Energyplan tests.patch), or the change is exempt.🤖 Generated with Claude Code