Repository navigation
feat(syntax): read more Snowflake statements into typed trees and re-baseline form coverage - #224
Merged
Merged
Conversation
…le parsed negatives Work in progress, not yet reviewed or gated. - Operands the pages name as objects (role, schema, stage, ...) get the identifier class; contact purposes, privileges and similar bare words get a word class with a string-literal wrong-kind case; more numeric names (days, precision, seconds) get the integer class. - Suppress notes that still said 'a valid operand' follow the new class notes, so no hand row is withdrawn. - Derived negatives Snowflake parses and fails later are observed under the settle rule instead of expected rejections. Verified: syntax_obligations_snowflake unit tests; obligation ids unchanged for every surviving obligation.
…, CONNECTION and DCM PROJECT Work in progress, not yet reviewed or gated. - AlterObject.name is optional; ALTER USER without a name records none instead of an empty name. - CREATE TAG (with ALLOWED_VALUES as one list), CREATE CONNECTION and CREATE DCM PROJECT build create_object trees instead of raw text. Verified: cargo test -p sqlquack-syntax-snowflake; cargo check --workspace --tests.
…gatives Work in progress, not yet reviewed or gated.
Work in progress, not yet reviewed or gated.
…nt, flag a token's own IF [NOT] EXISTS
…nce names, LIKE patterns and tags as operands
… quoted contact purpose
…e tree with their values
…AG, and refuse reserved words as INSERT, MERGE, LIKE, SET and UNSET names Work in progress, not yet reviewed or gated.
…, and pin their evidence Work in progress, not yet reviewed or gated.
…view brief version 1 Work in progress, not yet gated.
…e-only re-reviews under review brief version 1 Work in progress, not yet gated.
…poses and grant targets as tree fields Keeps an optional WITH before TAG or CONTACT in property kinds, records FORCE as a property instead of an action suffix, keeps the quoting of UNSET parameter names, marks string contact purposes, and gives grant and revoke separate caller, bulk and container fields instead of packing them into privilege names and the object kind. Work in progress: cargo check passes for the Snowflake, Postgres, BigQuery and Databricks crates; the crate test suites have not been run and expectations are not yet updated.
…ction strings, and test the kept tree fields An identifier left out between two dots, as the schema of d1..t1 or of SNOWFLAKE..<class>, is now marked omitted, so it differs from an absent part and still prints back as a..b. FORCE, CASCADE and RECOVERY after policy and Openflow actions become properties. INHERITED and CALLER come once, before the privilege list. A quoted stage name with blanks after FROM @ in ALTER SERVICE settles from its receipt as an undocumented outcome. Work in progress: the Snowflake, Postgres, BigQuery, Databricks, DuckDB, SQLite, SQL Server and ClickHouse syntax crate tests pass; coverage has not been rebuilt.
…w brief version 1 and pin the ALTER SERVICE settle Work in progress, not yet gated.
… was The omitted marker on identifiers is withdrawn; the representation is settled in a later change. Work in progress: the syntax crate tests pass.
Resource monitor trigger percentages and CODE BUNDLE / NOTEBOOK PROJECT FROM sources must be literals of the recorded kind, a COPY transform column takes no string after a dot, and RECLUSTER MAX_SIZE parses a string that Snowflake rejects only semantically. Regenerate the ALTER SERVICE obligations, drop unobservable records whose obligations no longer exist, and refresh the syntax baseline.
…ules Move CREATE FUNCTION parsing out of the commands module, return a user credential action's existence flags instead of mutating a parameter, read a procedure's EXECUTE AS in its own helper, keep the template operand switch with the other grammar constants, and parametrize the derived limit test.
Contributor
Author
Drops, rejection causes and known remaining items1. Drops (43)Failed the final review under brief v1 (22):
New cases still without receipts (19):
Changed cases awaiting review (2):
2. Rejection causes other than the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Many Snowflake forms parsed into opaque strings or lost keywords, so reviewers could not verify them against the frozen form review brief (version 1).
Changes
Verification
a..bis still serialized as"", which conflicts with brief v1 (d). 297 rejected forms cite it; 256 of them stay verified on earlier reviews of the same tree. A follow-up settles the representation with a brief clarification.svc!roleraw string and the GRANT OWNERSHIP class kind string.make check-syntaxandmake check-cipass on the final head.