Skip to content

docs(syntax-coverage): list the known gaps of the Snowflake form review - #226

Merged
kvlonge merged 1 commit into
mainfrom
docs/syntax-known-gaps
Nov 14, 2026
Merged

kvlonge merged 1 commit into
mainfrom
docs/syntax-known-gaps

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

The Snowflake syntax coverage README did not say which known gaps keep forms unverified under form review brief version 1, or how many forms each affects. This pull request also carries the release notes for the typed-tree and coverage work merged in #224, whose commits landed one by one.

Changes

  • The README's known-gaps section lists the a..b empty name part (297 forms), list items without a second-item case (461 verified, 203 unverified), MERGE actions (1), SERVICE ROLE names (2), the GRANT OWNERSHIP class kind (1) and the six docs pages changed after the pin (16 forms).

Verification

  • Counts come from the final review round's verdicts, the catalogue and the coverage snapshot on main.
  • Hygiene scan clean; documentation only, no generated file changes.

BEGIN_COMMIT_OVERRIDE
feat(snowflake): parse CREATE TASK, CREATE VARIABLE, CREATE TAG, CONNECTION, DCM PROJECT and ALTER WAREHOUSE into typed trees
feat(snowflake): keep routine and task properties, WITH, FORCE, quoted UNSET names, contact purposes and grant targets as tree fields
feat(syntax-coverage): classify Snowflake name, word, numeric and placeholder operands, each with a wrong-kind case
feat(syntax-coverage): re-baseline Snowflake form coverage to 2,826 verified of 3,479 forms (from 2,730)
fix(snowflake): record no name for an unnamed ALTER USER or ON ACCOUNT grant, and flag an access token's own IF [NOT] EXISTS
fix(snowflake): refuse reserved words as INSERT, MERGE, LIKE, SET and UNSET names
END_COMMIT_OVERRIDE

@kvlonge
kvlonge enabled auto-merge November 14, 2026 03:17
@kvlonge
kvlonge added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit cc0d126 Nov 14, 2026
9 checks passed
@kvlonge
kvlonge deleted the docs/syntax-known-gaps branch November 14, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant