Repository navigation
docs(syntax-coverage): list the known gaps of the Snowflake form review - #226
Merged
Merged
Conversation
…ew with their form counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Snowflake syntax coverage README did not say which known gaps keep forms unverified under form review brief version 1, or how many forms each affects. This pull request also carries the release notes for the typed-tree and coverage work merged in #224, whose commits landed one by one.
Changes
a..bempty name part (297 forms), list items without a second-item case (461 verified, 203 unverified), MERGE actions (1), SERVICE ROLE names (2), the GRANT OWNERSHIP class kind (1) and the six docs pages changed after the pin (16 forms).Verification
BEGIN_COMMIT_OVERRIDE
feat(snowflake): parse CREATE TASK, CREATE VARIABLE, CREATE TAG, CONNECTION, DCM PROJECT and ALTER WAREHOUSE into typed trees
feat(snowflake): keep routine and task properties, WITH, FORCE, quoted UNSET names, contact purposes and grant targets as tree fields
feat(syntax-coverage): classify Snowflake name, word, numeric and placeholder operands, each with a wrong-kind case
feat(syntax-coverage): re-baseline Snowflake form coverage to 2,826 verified of 3,479 forms (from 2,730)
fix(snowflake): record no name for an unnamed ALTER USER or ON ACCOUNT grant, and flag an access token's own IF [NOT] EXISTS
fix(snowflake): refuse reserved words as INSERT, MERGE, LIKE, SET and UNSET names
END_COMMIT_OVERRIDE