Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5aac5b4
wip: replace_key on delete_insert for groups of rows
kvlonge Nov 16, 2026
69872c5
test: DuckShop edge case replacing every version of a shipment by rep…
kvlonge Nov 16, 2026
23dbfaa
wip: plan note on delete_insert models matched by unique_key (pending…
kvlonge Nov 16, 2026
8a4c82b
Revert "wip: plan note on delete_insert models matched by unique_key …
kvlonge Nov 16, 2026
6510219
docs: point delete_insert group keys at replace_key
kvlonge Nov 16, 2026
75e666e
fix: reject replace_key on microbatch and non-incremental models
kvlonge Nov 16, 2026
7b62717
fix: refuse replace_key on BigQuery when planning
kvlonge Nov 16, 2026
486d5be
Merge remote-tracking branch 'origin/main' into feat/delete-insert-re…
kvlonge Nov 16, 2026
4fd6f5a
refactor: drop a standalone comment from delete_insert dispatch
kvlonge Nov 16, 2026
1be5930
fix: name every adapter that replaces groups in the A012 refusal
kvlonge Nov 16, 2026
a76d50b
Merge remote-tracking branch 'origin/main' into feat/delete-insert-re…
kvlonge Nov 16, 2026
b40080b
refactor: pick the delete key once in the incremental executor
kvlonge Nov 16, 2026
69e737b
feat: interpolate templates inside quoted config template arguments
kvlonge Nov 16, 2026
4f80bf3
fix: keep config template scanning linear and document the TOML escape
kvlonge Nov 16, 2026
f19d9fd
test: bound the config template scan by a step count
kvlonge Nov 16, 2026
29d1c47
chore: adopt fensu 0.31.1
kvlonge Nov 16, 2026
9944cc7
Merge branch 'feat/delete-insert-replace-key' into feat/replace-key-t…
kvlonge Nov 16, 2026
7f3a453
Merge branch 'feat/template-quoted-interpolation' into feat/replace-k…
kvlonge Nov 16, 2026
577a907
refactor: return the template scan's step count instead of mutating it
kvlonge Nov 16, 2026
9b17d5b
chore: raise the bindings crate cap for replace_key
kvlonge Nov 16, 2026
b1bcb78
Merge branch 'feat/template-quoted-interpolation' into feat/replace-k…
kvlonge Nov 16, 2026
5f7cac2
ci: decide trusted release checks from the run conclusion
kvlonge Nov 16, 2026
e23c6d6
Merge remote-tracking branch 'origin/main' into feat/replace-key-temp…
kvlonge Nov 16, 2026
6217075
ci: give the trusted release check lookup ten minutes and surface its…
kvlonge Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ jobs:
RELEASE_PR: ${{ needs.release-please.outputs.release_pr }}
REQUEST_ID: ${{ github.run_id }}-${{ github.run_attempt }}
run: |
set -uo pipefail
head_sha="$(git rev-parse HEAD)"
recovery="rerun the failed Release Please job to re-check"
post_status() {
Expand Down Expand Up @@ -231,15 +232,18 @@ jobs:
workflow="${workflows[${index}]}"
context="${contexts[${index}]}"
run_id=""
for _ in {1..30}; do
# A dispatched run can take minutes to appear in the run list, and a failed lookup
# is retried rather than read as "not started yet".
for _ in {1..60}; do
run_id="$(gh run list --workflow "${workflow}" --branch "${RELEASE_BRANCH}" \
--event workflow_dispatch --limit 50 \
--json databaseId,headSha,displayTitle,createdAt \
--jq ".[] | select(.headSha == \"${head_sha}\"
--jq "[.[] | select(.headSha == \"${head_sha}\"
and (.displayTitle | endswith(\" [${REQUEST_ID}]\"))
and .createdAt >= \"${dispatched_after}\") | .databaseId" | head -n 1)"
and .createdAt >= \"${dispatched_after}\") | .databaseId] | first // empty")" \
|| run_id=""
[[ -n "${run_id}" ]] && break
sleep 2
sleep 10
done
if [[ -z "${run_id}" ]]; then
post_status failure "${context}" "Trusted release check did not start"
Expand Down
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ tower-http = { version = "0.6", default-features = false, features = ["compressi
fensu-policy = "=0.22.0"
# Fensu's Python facts and core rules without their Python bindings: the default `python`
# feature adds PyO3, rusqlite, flate2 and sha2.
fensu-facts = { version = "=0.31.0", default-features = false }
fensu-native = { version = "=0.31.0", default-features = false }
fensu-facts = { version = "=0.31.1", default-features = false }
fensu-native = { version = "=0.31.1", default-features = false }
futures-util = { version = "0.3", default-features = false, features = ["std"] }
# `sqb` names compute log captures with random ids, as `uuid.uuid4().hex`.
getrandom = "0.4"
Expand Down
6 changes: 3 additions & 3 deletions benchmarks/duckshop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ project and does not change it:
`edge_running_peaks`, that a pre-hook of `int_edge_basket_running_peaks` creates
(`models/intermediate/edge_cases/_sqlbuild/_hooks/sql/`) and SQLBuild does not declare.

It has 167 models (13 staging, 140 intermediate, 14 marts), 5 Python functions, a SQL table
function, a hook-created JavaScript function, 192 unit tests and 4 scenarios, in nine groups:
It has 168 models (13 staging, 141 intermediate, 14 marts), 5 Python functions, a SQL table
function, a hook-created JavaScript function, 193 unit tests and 4 scenarios, in nine groups:

| Group | Covers |
|-------|--------|
Expand All @@ -136,7 +136,7 @@ function, a hook-created JavaScript function, 192 unit tests and 4 scenarios, in
| Ordering, numbers and text | NULL ordering under `DESC`; ties in ordered aggregates, `MAX_BY`, `MODE` and `ANY_VALUE`; default window frames; `UNION ALL BY NAME`; `ROUND` half-way values, decimal division, `MOD` and 38-digit amounts; integers past 2^53 against `FLOAT`; regular expressions and backslash escapes, and a scoped SQL macro collapsing whitespace whose body opens with a block comment and holds a line comment; `LIKE ... ESCAPE` and `ILIKE ANY`; `SPLIT_PART` and `SUBSTR` before the start; `NOT IN` with a NULL; names in many scripts; `JOIN ... USING` between `NUMBER(18,0)`, `NUMBER(38,0)` and text keys, with the types of the merged and qualified keys; NULL arithmetic and the types of NULL, decimal and exponent literals, `COUNT`, `ROW_NUMBER`, `%` and `NULLIF`; `MEDIAN` at scales 0 to 15; `DIV0` by literal zeros; `MODE`, `MEDIAN` and `COUNT_IF` over no rows; aggregates inside window functions and `QUALIFY`; `ROLLUP` totals; `TRUNC` of `FLOAT`; infinity words in other scripts; `CASE` without `ELSE` and `DECODE` over text; regular expressions with a `?` after a lazy quantifier, classes opening with `]`, empty matches and `.` against a carriage return; case-insensitive matches outside ASCII; `ILIKE` with a long s; `JAROWINKLER_SIMILARITY` of accented names in both cases; Base64 text with line feeds; `STARTSWITH`, `ENDSWITH`, `SUBSTRING`, `POSITION` with `IN` and with a comma, `CHARINDEX`, `CHR`, `REGEXP_SUBSTR_ALL`, `::STRING` and `CAST ... AS STRING`; `HEX_ENCODE`, `HEX_DECODE_STRING`, `TRY_HEX_DECODE_STRING` and `TRY_BASE64_DECODE_BINARY`; a comment attached to a text literal; `FLOOR` with and without a scale, `BITAND`, `ZEROIFNULL`, `::BIGINT` and `::DOUBLE`; `IS NOT DISTINCT FROM` and `EQUAL_NULL`; a comma join after an explicit join; `HASH_AGG` read in two row orders |
| Lineage and analysis | clauses whose columns decide rows without being output (`WHERE`, `QUALIFY`, `GROUP BY` by position and `ALL`, `ORDER BY` under `LIMIT`, `EXISTS`, a `FLATTEN` input, `ROLLUP` by position, `EXCEPT` under `LIMIT`); `RIGHT JOIN ... USING`, `NATURAL JOIN`, a `USING` key under a later outer join, and unmatched `ASOF JOIN` rows; `CONNECT BY` beside a column named `level`; a recursive CTE without `RECURSIVE` whose columns shift per iteration; `LAST_DAY` with a date part; positional columns and the names Snowflake gives unaliased expressions; `TEXT(5)` and widened `COUNT` contracts; `LAG` and `LEAD` with one, two and three arguments; a comma-joined `LATERAL` whose nested derived table reads the left item; relations aliased `first` and `last`, one without `AS`, the words of Snowflake's read-order clauses; untyped and typed `FILTER` lambdas over `ARRAY_AGG` in a grouped query; column expression ranges in compiled SQL that SQL and Python macros, a variable and cursor bounds rewrote, and columns qualified by their reference call, whose ranges are dropped |
| Python functions | volatile tokens and numbers from a column, a constant and no argument, and `DIV0` of a volatile call beside look-alike names, checked by assertions that hold for any values; a handler answering NULL input without `STRICT`; Python `None` as JSON null, and datetimes, Decimals and integers past 2^53 handed to `VARIANT` and `FLOAT` results |
| Scenarios and lifecycle | typed values across model boundaries; `VARIANT` expected output; a star under a lower-case contract and a quoted camelCase export; a snapshot keyed and compared on quoted camelCase columns; a cursor-window incremental model over far-apart fixture loads; a change log merged across two loads, checked against a full rebuild, and a keyed cursor `delete_insert` copy of it whose rows move out of the window between loads |
| Scenarios and lifecycle | typed values across model boundaries; `VARIANT` expected output; a star under a lower-case contract and a quoted camelCase export; a snapshot keyed and compared on quoted camelCase columns; a cursor-window incremental model over far-apart fixture loads; a change log merged across two loads, checked against a full rebuild, a keyed cursor `delete_insert` copy of it whose rows move out of the window between loads, and a cursor `delete_insert` copy of every version that `replace_key` replaces per shipment |
| Translation refusals | one model per construct that translation tools refuse or guard, most putting a construct refused only under strict checking before one refused by default, so a model shows both: `FLOAT` values through sums, averages, running totals, arrays, objects, `HASH`, `TO_CHAR` and `::NUMBER(38, 10)`; `VARIANT` dates, decimals and XML; `ARRAY_AGG` without `WITHIN GROUP`, sparse arrays and `ARRAY(NUMBER)` casts; `REDUCE`, `FILTER` and `TRANSFORM` lambdas; patterns and `REGEXP_REPLACE` replacements built from columns, and lazy patterns; `TRY_TO_DATE` with a format from a column; zoned literals, `CONVERT_TIMEZONE` from `CURRENT_TIMESTAMP`, `SEQ8`, `GENERATOR` with an expression `ROWCOUNT`; `PIVOT`, `ANY_VALUE`, `IGNORE NULLS` around `IFF`, unaliased columns read by Snowflake's name, `UNION` branches whose column is always NULL; `TO_NUMBER`, `TO_DECIMAL` and `TRY_BASE64_DECODE_BINARY`; an open (uncontracted) source `edge__supplier_notes`, the table function, read for one basket and after `LATERAL` for every basket, and the hook-created function. `rpt_edge_case_model_keys` and `rpt_edge_case_array_model_keys` read every model in the group, so a refusal there also refuses a downstream model |

Unit-test expectations in the edge-case area are captured on Snowflake under the `edge` target's
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
MODEL (
description """
Every delivered version of each shipment with a version loaded in the window, replaced as a
group by delete and insert. A shipment has several rows, so replace_key names the group key:
unique_key would promise one row per shipment.
""",
tags [edge_case],
materialized incremental,
incremental_strategy delete_insert,
replace_key [shipment_id],
cursor source_loaded_at,
cursor_type timestamp,
cursor_grain second,
cursor_inputs (
edge__delivery_updates _loaded_at,
),
columns (
delivery_id (type VARCHAR, nullable false, audits [not_null, unique]),
shipment_id (type VARCHAR, nullable false, audits [not_null]),
delivery_status (type VARCHAR),
is_delete (type BOOLEAN),
version_seq (type NUMBER(38, 0)),
source_loaded_at (type TIMESTAMP_NTZ, nullable false, audits [not_null]),
),
);

WITH touched AS (
SELECT DISTINCT u.shipment_id
FROM __source("edge__delivery_updates") AS u
WHERE
u._loaded_at >= __cursor_start()
AND u._loaded_at < __cursor_end()
),

final AS (
SELECT
v.delivery_id,
v.shipment_id,
v.delivery_status,
v.is_delete,
v.version_seq,
MAX(v.loaded_at) OVER (PARTITION BY v.shipment_id) AS source_loaded_at
FROM __ref("int_edge_delivery_update_versions") AS v
WHERE
v.loaded_at < __cursor_end()
AND v.shipment_id IN (
SELECT t.shipment_id
FROM touched AS t
)
)

SELECT *
FROM final
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
TEST (
name "int_edge_delivery_versions_replaced__copies_every_version_of_shipments_touched_in_the_window",
cursor_start "2026-03-02 00:00:00",
cursor_end "2026-03-03 00:00:00",
);

WITH __source__edge__delivery_updates AS (
SELECT
v.delivery_id,
v.shipment_id,
v.order_ref,
v.delivery_status,
v.ordered_on::DATE AS ordered_on,
v.delivered_on::DATE AS delivered_on,
v._op,
v._seq::NUMBER(38, 0) AS _seq,
v._loaded_at::TIMESTAMP_NTZ AS _loaded_at
FROM VALUES
('DU-01', 'SH-1', 'DS-O-3001', 'label_created', '2026-02-27', NULL, 'I', 10, '2026-03-01 10:00:00'),
('DU-04', 'SH-3', 'DS-O-3003', 'delivered', '2026-02-20', '2026-02-25', 'I', 30, '2026-03-01 10:00:00'),
('DU-06', 'SH-1', 'DS-O-3001', 'picked_up', '2026-02-27', NULL, 'U', 11, '2026-03-02 10:00:00'),
('DU-08', 'SH-2', 'DS-O-3002', 'delivered', '2026-02-28', '2026-03-02', 'U', 21, '2026-03-02 23:59:59'),
('DU-11', 'SH-6', 'DS-O-3006', 'label_created', '2026-03-02', NULL, 'I', 60, '2026-03-03 00:00:00') AS v(delivery_id, shipment_id, order_ref, delivery_status, ordered_on, delivered_on, _op, _seq, _loaded_at)
),

__ref__int_edge_delivery_update_versions AS (
SELECT
v.delivery_id,
v.shipment_id,
v.order_ref,
v.delivery_status,
v.ordered_on::DATE AS ordered_on,
v.delivered_on::DATE AS delivered_on,
v.is_delete,
v.version_seq::NUMBER(38, 0) AS version_seq,
v.loaded_at::TIMESTAMP_NTZ AS loaded_at
FROM VALUES
('DU-01', 'SH-1', 'DS-O-3001', 'label_created', '2026-02-27', NULL, FALSE, 10, '2026-03-01 10:00:00'),
('DU-02', 'SH-1', 'DS-O-3001', 'in_transit', '2026-02-27', NULL, FALSE, 12, '2026-03-01 10:00:00'),
('DU-04', 'SH-3', 'DS-O-3003', 'delivered', '2026-02-20', '2026-02-25', FALSE, 30, '2026-03-01 10:00:00'),
('DU-06', 'SH-1', 'DS-O-3001', 'picked_up', '2026-02-27', NULL, FALSE, 11, '2026-03-02 10:00:00'),
('DU-08', 'SH-2', 'DS-O-3002', 'delivered', '2026-02-28', '2026-03-02', FALSE, 21, '2026-03-02 23:59:59'),
('DU-12', 'SH-1', 'DS-O-3001', 'delivered', '2026-02-27', '2026-03-03', FALSE, 13, '2026-03-03 00:00:00'),
('DU-11', 'SH-6', 'DS-O-3006', 'label_created', '2026-03-02', NULL, FALSE, 60, '2026-03-03 00:00:00') AS v(
delivery_id,
shipment_id,
order_ref,
delivery_status,
ordered_on,
delivered_on,
is_delete,
version_seq,
loaded_at
)
),

__expected__int_edge_delivery_versions_replaced AS (
SELECT
'DU-01' AS delivery_id,
'SH-1' AS shipment_id,
10 AS version_seq,
'2026-03-02 10:00:00'::TIMESTAMP_NTZ(9) AS source_loaded_at
UNION ALL
SELECT
'DU-02' AS delivery_id,
'SH-1' AS shipment_id,
12 AS version_seq,
'2026-03-02 10:00:00'::TIMESTAMP_NTZ(9) AS source_loaded_at
UNION ALL
SELECT
'DU-06' AS delivery_id,
'SH-1' AS shipment_id,
11 AS version_seq,
'2026-03-02 10:00:00'::TIMESTAMP_NTZ(9) AS source_loaded_at
UNION ALL
SELECT
'DU-08' AS delivery_id,
'SH-2' AS shipment_id,
21 AS version_seq,
'2026-03-02 23:59:59'::TIMESTAMP_NTZ(9) AS source_loaded_at
)

SELECT 1
3 changes: 2 additions & 1 deletion crates/sqlbuild-analysis/src/planner_identity/constants.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Planner identity constants shared with the Python planner.

/// Model config keys whose values participate in version identity, in Python's insertion order after `cursor_inputs`.
pub const VERSION_IDENTITY_CONFIG_KEYS: [&str; 39] = [
pub const VERSION_IDENTITY_CONFIG_KEYS: [&str; 40] = [
"append_cursor_inclusive",
"batch_size",
"check_columns",
Expand Down Expand Up @@ -33,6 +33,7 @@ pub const VERSION_IDENTITY_CONFIG_KEYS: [&str; 39] = [
"snapshot_schema_change",
"snapshot_strategy",
"unique_key",
"replace_key",
"updated_at",
"valid_from_column",
"valid_to_column",
Expand Down
2 changes: 2 additions & 0 deletions crates/sqlbuild-analysis/src/planner_strategy/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ pub const PERMANENT_TABLE_TYPE: &str = "permanent";
pub const TRANSIENT_TABLE_DDL: &str = "TRANSIENT TABLE";
/// The permanent table DDL replacing the transient keyword.
pub const PERMANENT_TABLE_DDL: &str = "TABLE";
/// SQL dialects whose `delete_insert` cannot replace several rows per key.
pub const GROUP_REPLACEMENT_UNSUPPORTED_DIALECTS: [&str; 1] = ["bigquery"];
/// The warning code of an incremental model whose table keeps an outdated physical layout.
pub const PHYSICAL_LAYOUT_PENDING_WARNING_CODE: &str = "PHYSICAL_LAYOUT_PENDING";
/// Model config keys of a table's physical layout, in the order warnings name them.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
//! The refusal of `replace_key` on adapters that cannot replace groups of rows.

use crate::planner_strategy::constants::GROUP_REPLACEMENT_UNSUPPORTED_DIALECTS;

/// Why `model_name` cannot set `replace_key` on an adapter with SQL dialect `dialect`, if it cannot.
pub fn group_replacement_refusal(
model_name: &str,
(adapter_name, dialect): (&str, Option<&str>),
has_replace_key: bool,
) -> Option<String> {
let unsupported: bool = has_replace_key
&& dialect.is_some_and(|dialect| GROUP_REPLACEMENT_UNSUPPORTED_DIALECTS.contains(&dialect));
unsupported.then(|| {
format!(
"model '{model_name}' sets replace_key, but adapter '{adapter_name}' cannot replace \
groups of rows; use unique_key with one row per key, or replace groups on any \
adapter other than BigQuery"
)
})
}
1 change: 1 addition & 0 deletions crates/sqlbuild-analysis/src/planner_strategy/main/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ pub mod count_timeline_batches;
pub mod cursor_input_column;
pub mod cursor_type_warning;
pub mod effective_run_scope;
pub mod group_replacement_refusal;
pub mod lineage_reference;
pub mod materialization_type;
pub mod microbatch_limit_warning;
Expand Down
2 changes: 2 additions & 0 deletions crates/sqlbuild-analysis/src/planner_strategy/tests.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#[path = "tests/test_group_replacement_refusal.rs"]
mod group_replacement_refusal;
#[path = "tests/helpers.rs"]
mod helpers;
#[path = "tests/test_model_entry.rs"]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
use crate::planner_strategy::main::group_replacement_refusal::group_replacement_refusal;
use crate::planner_strategy::tests::test_types::GroupReplacementRefusalTestCase;

#[test]
fn given_replace_key_when_planning_then_only_bigquery_refuses_it() {
let test_cases = [
GroupReplacementRefusalTestCase {
description: "BigQuery's delete_insert matches one source row per target row",
dialect: Some("bigquery"),
has_replace_key: true,
expected_refused: true,
},
GroupReplacementRefusalTestCase {
description: "BigQuery with unique_key keeps its delete_insert",
dialect: Some("bigquery"),
has_replace_key: false,
expected_refused: false,
},
GroupReplacementRefusalTestCase {
description: "Snowflake deletes every row of a key",
dialect: Some("snowflake"),
has_replace_key: true,
expected_refused: false,
},
GroupReplacementRefusalTestCase {
description: "an adapter without SQL analysis",
dialect: None,
has_replace_key: true,
expected_refused: false,
},
];

for test_case in test_cases {
let refusal = group_replacement_refusal(
"forecast_lines",
("warehouse", test_case.dialect),
test_case.has_replace_key,
);

assert_eq!(
refusal.is_some(),
test_case.expected_refused,
"{}",
test_case.description
);
}
assert_eq!(
group_replacement_refusal("forecast_lines", ("bigquery", Some("bigquery")), true)
.as_deref(),
Some(
"model 'forecast_lines' sets replace_key, but adapter 'bigquery' cannot replace groups of \
rows; use unique_key with one row per key, or replace groups on any adapter other \
than BigQuery"
)
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ pub(super) struct TableTypeDdlTestCase {
pub(super) expected_ddl: &'static str,
}

pub(super) struct GroupReplacementRefusalTestCase {
pub(super) description: &'static str,
pub(super) dialect: Option<&'static str>,
pub(super) has_replace_key: bool,
pub(super) expected_refused: bool,
}

pub(super) struct PhysicalLayoutWarningTestCase {
pub(super) description: &'static str,
pub(super) materialization: MaterializationType,
Expand Down
3 changes: 2 additions & 1 deletion crates/sqlbuild-config/src/project/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pub(crate) const DEFAULTS_KEYS: [&str; 33] = [
"unaccounted_partition_policy",
];
/// The MODEL header keys, which `[path_defaults]` entries may set.
pub(crate) const MODEL_HEADER_KEYS: [&str; 73] = [
pub(crate) const MODEL_HEADER_KEYS: [&str; 74] = [
"alias",
"append_cursor_inclusive",
"audit_factories",
Expand Down Expand Up @@ -158,6 +158,7 @@ pub(crate) const MODEL_HEADER_KEYS: [&str; 73] = [
"post_hooks",
"pre_hooks",
"primary_key",
"replace_key",
"replay_on_change",
"row_diff_exclude_columns",
"row_diff_sample_rows",
Expand Down
Loading
Loading