Repository navigation
feat: replace_key for delete_insert and templates inside quoted config arguments - #1518
Merged
Merged
Conversation
…(pending decision)" This reverts commit 23dbfaa.
The malformed nested-template guard now counts the characters the scan visits instead of timing it, and the docs say a template nested past the limit stays as written text.
fensu-facts and fensu-native move to =0.31.1 and the fensu tool to >=0.31.1. fensu-policy stays at 0.22.0. The unreachable-definitions scaling bound stays at 6.5.
The scan helpers return the characters they visit with their result, their docs fit one line, the linear-scan guard uses named cases with an expected step bound, and the build test builds each case in place.
Raised from 197,891 to 197,921: replace_key plan-entry plumbing and the A012 refusal, +31 together with sqlbuild-python-base.
gh run watch --exit-status fails for a run that finished before the watch started, which failed release pull request checks whose trusted runs had passed. The loop now watches only a run still in progress and passes the check only when the finished run concluded success.
…late-args # Conflicts: # fensu.toml
… errors A release pull request check failed with "did not start" because the dispatched Release Distributions run did not appear in the run list within the lookup's two minutes. Without pipefail, a failing run list call in that loop looked the same as a run not listed yet. The lookup now polls for up to ten minutes, retries a failed run list call, picks the first match in jq instead of a head pipe, and the step runs with nounset and pipefail. A run that never appears still fails the check with the same message. This also drops the earlier change to the watch: gh run watch already passes a run that finished successfully before the watch started, so that change handled no real case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
delete_insertbyunique_keyis used to replace groups of rows, butunique_keypromises one row per key andSQLCLEAN018trusts it. Config templates could not read a template inside a quoted argument, such as${coalesce('${ENV:SCHEMA}', 'dev')}. A release PR check failed with "did not start": the dispatched run was not found within the lookup's 2 minutes, from list lag or from agh run listerror the pipe hid.Changes
replace_keyfor incrementaldelete_insert: deletes rows whosereplace_keyvalues are in the delta, then inserts it. Not withunique_key, microbatch or non-incremental; never a uniqueness proof forSQLCLEAN018; BigQuery refuses it (A012).${...}inside quoted arguments, up to eight levels deep, in linear time; malformed bodies keep their errors. Docs added.set -uo pipefail, 60 polls × 10 s, a failedgh run listis logged and retried. Lag: found later. Error: retried. A run that never appears still fails "did not start".sqlbuild-python-base):replace_keyplan plumbing,A012.Verification
replace_key: Rust validation and refusal cases; integration build replaces all rows of one key; E2ESQLCLEAN018still flagsROW_NUMBERover areplace_keycolumn. Snowflake: a window rebuild keeps each group equal to its upstream rows.gherror.make check-ci.DuckShop: new
int_edge_delivery_versions_replacededge case forreplace_key. Quoted templates are config expansion, covered by E2E.