Repository navigation
fix(ui): cut noise from the overview alerts and the plan page - #1480
Merged
Merged
Conversation
Group alerts that share a cause, wrap their messages, word short heartbeat gaps as pauses and state the out-of-date counts plainly. On the plan page, drop the narration sentence, word the --changed rule and what a preview can't know, collapse unchanged nodes, show the forward-only warning under its model, and limit the alert banner to problems that affect the plan.
…rview WIP: review fixes on the noise pass.
WIP: held-back rows drop the countdown while no server runs the scheduler.
…ate build button (WIP) The plan page shows facts and status only: the forward-only replay warning, the --changed rule sentence and the synced-preview box are gone. Alert icons sit centred in their square again with room before the title. The out-of-date alert offers one build: what changed when anything changed, else a rebuild of the nodes behind. Acknowledged unresponsive runs no longer hide queued runs, consequence rows are keyed by position, and a plan warning attaches to one entry only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Overview alert list and the plan page repeated themselves and buried the one thing to act on. Alerts with a shared cause were listed separately, messages were cut off mid-sentence, a one-minute heartbeat gap read as an outage, and the stale counts were ambiguous. The plan page explained what its rows already said, pasted the CLI's long replay advice, and showed every location alert.
Changes
Overview:
--changedplan) when anything changed, else "Rebuild N" for the nodes behind. The header no longer repeats the row.Plan:
--changedrule, the preview box and the forward-only replay advice are gone. The CLI's warning text is unchanged.Verification
npm run check,npm test(251, with new tests for alert grouping, stale wording and button choice, warnings and held-back text) andnpm run buildpass.