You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6d34620
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ui): cut noise from the overview alerts and the plan page (#1480)
* fix(ui): cut noise from the overview alerts and the plan page
Group alerts that share a cause, wrap their messages, word short heartbeat
gaps as pauses and state the out-of-date counts plainly. On the plan page,
drop the narration sentence, word the --changed rule and what a preview
can't know, collapse unchanged nodes, show the forward-only warning under
its model, and limit the alert banner to problems that affect the plan.
* fix(ui): plain replay warning, clearer stale counts, quieter demo overview
WIP: review fixes on the noise pass.
* fix(ui): say held-back jobs wait for a stopped scheduler
WIP: held-back rows drop the countdown while no server runs the scheduler.
* fix(ui): drop explanatory plan text, centre alert icons, one out-of-date build button (WIP)
The plan page shows facts and status only: the forward-only replay warning,
the --changed rule sentence and the synced-preview box are gone. Alert icons
sit centred in their square again with room before the title. The out-of-date
alert offers one build: what changed when anything changed, else a rebuild of
the nodes behind. Acknowledged unresponsive runs no longer hide queued runs,
consequence rows are keyed by position, and a plan warning attaches to one
entry only.
nodes: [node('fact_orders','changed','SQL changed: refunded payments now net out of order revenue',{columns: [{name: 'net_revenue',op: 'changed',detail: 'expression changed'}]})],
368
+
nodes: [
369
+
node('fact_orders','changed','SQL changed: refunded payments now net out of order revenue',{columns: [{name: 'net_revenue',op: 'changed',detail: 'expression changed'}]}),
370
+
node('customer_status','changed','SQL changed: lapsed customers now need 120 days without an order',{columns: [{name: 'status',op: 'changed',detail: 'expression changed'}]})
expect(detail(['model:a','model:b'],['model:b']).title).toBe('2 nodes out of date');
81
+
expect(detail(['model:a','model:b'],['model:b']).detail).toBe('2 changed since their last build, 1 of them also behind an upstream rebuild: a, b');
82
+
expect(detail(['model:a','model:b'],['model:b','model:c']).detail).toBe('2 changed since their last build, 1 of them also behind an upstream rebuild, and 1 more behind an upstream rebuild: a, b, c');
83
+
expect(detail(['model:a'],['model:c']).detail).toBe('1 changed since its last build and 1 behind an upstream rebuild: a, c');
84
+
expect(detail(['model:a'],['model:a']).detail).toBe('1 changed since its last build, also behind an upstream rebuild: a');
85
+
expect(detail([],['model:c','model:d']).detail).toBe('2 behind an upstream rebuild: c, d');
0 commit comments