Repository navigation
fix: refuse name-based run IDs and fail seeds whose audits fail - #1469
Merged
Merged
Conversation
…c requests The server derives version 5 run IDs for group members, retries, sensor and scheduled runs. A person-supplied version 5 ID could collide with one of those, so job run, rerun and ad-hoc requests now refuse it with a 400 that says why. Internal paths keep their derived IDs.
The seed was reported as a success before its audits ran, so server runs showed it succeeded while its dependants were skipped. The audits now run first and a failing one turns the seed result into a failure with R006, as a failing final audit does for a model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Changes
POST /api/control/runs,/runs/adhocand/runs/rerun(andsqb server admin request-run/rerun-run) refuse a version 5run_idwith a 400 that says why. The server's own derived IDs don't pass through this check. The OpenAPI document, the TypeScript client and the server docs say which IDs to send.Verification
run_idon all three endpoints returns 400 with the message on SQLite and PostgreSQL, and a random ID is still accepted. It fails with the check disabled.failedwith R006 and its message, and the model reading it is skipped. It fails on main.resource_attempt_failedwith R006 when its audit fails, and completed when it passes.make check-cipasses on the final head.