Repository navigation
Commit f83b16c
authored
fix: refuse name-based run IDs and fail seeds whose audits fail (#1469)
* fix(server): refuse name-based run IDs on person run, rerun and ad-hoc requests
The server derives version 5 run IDs for group members, retries, sensor
and scheduled runs. A person-supplied version 5 ID could collide with one
of those, so job run, rerun and ad-hoc requests now refuse it with a 400
that says why. Internal paths keep their derived IDs.
* fix(build): fail a seed whose error-severity audit fails
The seed was reported as a success before its audits ran, so server runs
showed it succeeded while its dependants were skipped. The audits now run
first and a failing one turns the seed result into a failure with R006,
as a failing final audit does for a model.1 parent d9c6858 commit f83b16c
22 files changed
Lines changed: 396 additions & 33 deletions
File tree
- benchmarks/duckshop/edge_cases/orchestration
- clients/typescript/src
- crates/sqlbuild-orchestration
- src
- api/_helpers/resources
- runs
- _helpers/requests
- tests/api
- src/sqlbuild
- .agents/skills/sqlbuild/references/docs/cli
- executor/build/classes
- tests
- e2e/src/sqlbuild/cli/commands/main
- build
- seed
- integration/src/sqlbuild/compiler/compiled_project/publication
- website/src/content/docs/docs/cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1450 | 1450 | | |
1451 | 1451 | | |
1452 | 1452 | | |
1453 | | - | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
1454 | 1457 | | |
1455 | 1458 | | |
1456 | 1459 | | |
| |||
1883 | 1886 | | |
1884 | 1887 | | |
1885 | 1888 | | |
1886 | | - | |
| 1889 | + | |
| 1890 | + | |
| 1891 | + | |
| 1892 | + | |
1887 | 1893 | | |
1888 | 1894 | | |
1889 | 1895 | | |
| |||
2688 | 2694 | | |
2689 | 2695 | | |
2690 | 2696 | | |
2691 | | - | |
| 2697 | + | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
2692 | 2701 | | |
2693 | 2702 | | |
2694 | 2703 | | |
| |||
6065 | 6074 | | |
6066 | 6075 | | |
6067 | 6076 | | |
| 6077 | + | |
| 6078 | + | |
| 6079 | + | |
| 6080 | + | |
| 6081 | + | |
| 6082 | + | |
| 6083 | + | |
| 6084 | + | |
6068 | 6085 | | |
6069 | 6086 | | |
6070 | 6087 | | |
| |||
6225 | 6242 | | |
6226 | 6243 | | |
6227 | 6244 | | |
| 6245 | + | |
| 6246 | + | |
| 6247 | + | |
| 6248 | + | |
| 6249 | + | |
| 6250 | + | |
| 6251 | + | |
| 6252 | + | |
6228 | 6253 | | |
6229 | 6254 | | |
6230 | 6255 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
148 | 149 | | |
149 | 150 | | |
150 | 151 | | |
151 | | - | |
| 152 | + | |
| 153 | + | |
152 | 154 | | |
153 | 155 | | |
154 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
222 | 223 | | |
223 | 224 | | |
224 | 225 | | |
| 226 | + | |
225 | 227 | | |
226 | 228 | | |
227 | 229 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
| |||
211 | 212 | | |
212 | 213 | | |
213 | 214 | | |
| 215 | + | |
214 | 216 | | |
215 | 217 | | |
216 | 218 | | |
| |||
742 | 744 | | |
743 | 745 | | |
744 | 746 | | |
| 747 | + | |
745 | 748 | | |
746 | 749 | | |
747 | 750 | | |
| |||
0 commit comments