Skip to content

drop unsupported sonar per test coverage #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanjbaxter merged 2 commits into from
Oct 2, 2026
+0 −17
Merged

drop unsupported sonar per test coverage #704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf9bd7d
fix
wind57 Oct 2, 2026
ffadf35
code review comments
wind57 Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@
<maven-deploy-plugin.version>3.2.0</maven-deploy-plugin.version>
<readme.main.classpath>${docs.classes.dir}</readme.main.classpath>
<readme.class.path>readme.class.path</readme.class.path>
<sonar-jacoco-listeners.version>5.14.0.18788</sonar-jacoco-listeners.version>

@wind57 wind57 Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in spring-cloud-kurbernetes we have this failure:

https://github.com/spring-cloud/spring-cloud-kubernetes/actions/runs/37047671159/job/110974269610?pr=2340

org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException There was an error in the forked process
  org/junit/runner/notification/RunListener
  java.lang.NoClassDefFoundError: org/junit/runner/notification/RunListener

this happens because we now use surefire 3.6.0 that does not ignore these listeners ( it used to in the previous version 3.5.6 ). This is a junit-4 listener and in spring-cloud-kubernetes we do not have junit-4 dependencies.

This listener offers per test coverage, which is unsupported by sonar anyway: https://community.sonarsource.com/t/no-information-about-coverage-by-test/2999

so we can drop it. This will require a new version to be published so that we can use it

<duplicate-finder-maven-plugin.version>2.0.1</duplicate-finder-maven-plugin.version>
<duplicate-finder-maven-plugin.printEqualFiles>false</duplicate-finder-maven-plugin.printEqualFiles>
<duplicate-finder-maven-plugin.failBuildInCaseOfDifferentContentConflict>false</duplicate-finder-maven-plugin.failBuildInCaseOfDifferentContentConflict>
Expand Down Expand Up @@ -1464,25 +1463,9 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>

@ryanjbaxter ryanjbaxter Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just drop the configuration here and not the entire plugin?

@wind57 wind57 Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<properties>
<property>
<name>listener</name>
<value>org.sonar.java.jacoco.JUnitListener</value>
</property>
</properties>
</configuration>
</plugin>
</plugins>
</build>
<dependencies>
<dependency>
<groupId>org.sonarsource.java</groupId>
<artifactId>sonar-jacoco-listeners</artifactId>
<version>${sonar-jacoco-listeners.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
</profile>
<profile>
<id>license</id>
Expand Down
Loading