drop unsupported sonar per test coverage - #704
Conversation
| <maven-deploy-plugin.version>3.2.0</maven-deploy-plugin.version> | ||
| <readme.main.classpath>${docs.classes.dir}</readme.main.classpath> | ||
| <readme.class.path>readme.class.path</readme.class.path> | ||
| <sonar-jacoco-listeners.version>5.14.0.18788</sonar-jacoco-listeners.version> |
There was a problem hiding this comment.
in spring-cloud-kurbernetes we have this failure:
org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException There was an error in the forked process
org/junit/runner/notification/RunListener
java.lang.NoClassDefFoundError: org/junit/runner/notification/RunListener
this happens because we now use surefire 3.6.0 that does not ignore these listeners ( it used to in the previous version 3.5.6 ). This is a junit-4 listener and in spring-cloud-kubernetes we do not have junit-4 dependencies.
This listener offers per test coverage, which is unsupported by sonar anyway: https://community.sonarsource.com/t/no-information-about-coverage-by-test/2999
so we can drop it. This will require a new version to be published so that we can use it
|
@ryanjbaxter can you look at this one please and tell me what you think? |
|
I think I remember him working on that error somewhere else |
|
@spencergibb No not this specific one. I think this is fine since we don't use junit 4 anyways |
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>${maven-surefire-plugin.version}</version> | ||
| <configuration> |
There was a problem hiding this comment.
Can we just drop the configuration here and not the entire plugin?
Signed-off-by: wind57 <eugen.rabii@gmail.com>
4 participants
No description provided.