Make resourceScope callable from Scala 3.9 - #513
Merged
Merged
Conversation
adamw
added a commit
to VirtusLab/orca
that referenced
this pull request
Sep 23, 2026
Removes the `onRoleResolved` callback and the `roles`/`transferred` vars from `buildContext`. Agents are now closed by one Ox `resourceScope` that covers building the context and running the flow. Needs Ox 1.0.8: earlier versions fail with `NoSuchMethodError` when `resourceScope` is called from Scala 3.9 (scala/scala3#24653, fixed in softwaremill/ox#513).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code compiled with Scala 3.9 fails when calling
resourceScope:Scala 3.9 compiles a method whose result is an alias of
Unitto returnvoid. Ox is built with 3.3, which compiles it to returnBoxedUnit. See scala/scala3#24653.The fix uses the workaround from that issue:
NoEnclosingConcurrencyScopenow extends a trait that declares the same method with aUnitresult, so the compiler emits both versions. Tested withresourceScope(42)compiled with Scala 3.3.8, 3.9.0 and the current nightly. MiMa passes.