Replace RoleAgents.onRoleResolved with an Ox resource scope - #197
Merged
Merged
Conversation
Scala 3.9 can't link it (scala/scala3#27140), so this waits for a fix.
It links from Scala 3.9 (softwaremill/ox#513).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
onRoleResolvedcallback and theroles/transferredvars frombuildContext. Agents are now closed by one OxresourceScopethat covers building the context and running the flow.Needs Ox 1.0.8: earlier versions fail with
NoSuchMethodErrorwhenresourceScopeis called from Scala 3.9 (scala/scala3#24653, fixed in softwaremill/ox#513).