Repository navigation
feat(ui): one solid locality ring; hue alone says where your words go - #68
Merged
Merged
Conversation
Drop the dotted network and dashed-orbit remote variants and the provider monogram badge. Every locality now draws the same solid ring; only the hue changes, and the label still names the destination. - LocalityRing loses the provider and active props and data-active - Remove dash, orbit, badge CSS and --motion-locality-orbit - Remove providerMonogram (badge-only helper) - Update DESIGN.md and spec D4; rewrite ring tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locality ring had three shapes (solid, dotted, dashed with a spinning orbit) and a provider monogram badge. That was too much to polish for one small mark. The review mock settled on one solid ring for every locality, so this change brings the app in line with it.
Every
LocalityRingnow draws the same solid circle. Only the hue changes (green for this device, blue for your own server, amber for a provider), and the ring's label still names the destination. The Sealed strike-through still works.provider/activeprops anddata-active,--motion-locality-orbit, the history-only badge size rule, and theproviderMonogramhelper, which only the badge used.--motion-base), matching the mock.Proof: I rendered the real component with the built renderer CSS in Chromium. All three localities show a solid stroke with no dashes and no animation, in the right light and dark hues, and the blocked strike still renders. Lint, typecheck,
format:check,build:rendererand the rewritten ring tests pass. The full suite passes apart from one test that fails locally because the machine is short on disk space (downloadModel … concurrently, unrelated).Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code