Repository navigation
fix(auth): block only curated disposable domains, and never gate SSO or SCIM provisioning - #9529
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issue was found. SummaryNarrows disposable-email blocking to the curated list and exempts SSO and SCIM account creation.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
…or SCIM provisioning
…lback paths from the plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
waleedlatif1
force-pushed
the
fix/disposable-email-false-positives
branch
from
October 31, 2026 18:15
b0c26b2 to
726a69b
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disposable/disposable-email-domainslist (~98.5k) and the curated CC0disposable-email-domainsblocklist. The auto-generated list includes real companies and ISP mail (railway.com, namecheap.com, q.com, yandex.net, cafe24.com, domain.com…) and public suffixes (msk.ru, it.com, pp.ua, dyndns.org, ddns.net…) which, with parent-domain matching, refused every*.msk.rucompanybun run vendor:disposable-email-domainsfrom the same pinned commit: entries that aren't a registrable domain undertldts(ICANN or private suffixes) are dropped, relays moved out of runtime, and a commented list of real providers removed (21cn.com, hola.org, sify.com). 10,079 domains (was 98,687); the Tranco top-20k intersection is 7, all genuinely disposable/dynamic-DNS/admin/create-user, whose 403 made IdPs retry forever) and SSO callbacks (domain-verified providers) skip the check; email signup, social OAuth and generic OAuth stay gated@with a trailing dot stripped; fail-open on load error keptType of Change
Testing
disposable.test.ts: listed/subdomain/case/trailing-dot/quoted-@refused;company.msk.ru,acme.it.com, railway.com, relays and gmail allowed; invariant that the JSON contains no public suffix. 8 cases fail on the old code and listdisposable-email-gate.test.ts(realbetterAuth+ memory adapter + admin plugin): disposable email signup refused withDISPOSABLE_EMAIL,company.msk.rusignup succeeds, SCIMcreateUsersucceeds, SSO callback paths skip, social/generic OAuth gated; disabling the skip turns SCIM and SSO redChecklist
test-auditauthoring gate)