Skip to content

chore(auth): correct where the short disposable list runs - #9535

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/disposable-signup-polish
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/disposable-signup-polish

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Documentation

Testing

  • Comment-only change; biome on the file; CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 6:36pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This documentation-only change appears safe to merge.

Summary

Corrects the documentation for isDisposableEmail.

  • The email comment explains why browser checks keep a short disposable list.

Reviews (2) · Last reviewed commit: "chore(auth): correct where the short dis..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1 waleedlatif1 changed the title improvement(auth): tighten the disposable-email signup gate and cover its failure modes chore(auth): correct where the short disposable list runs Oct 31, 2026
@waleedlatif1
waleedlatif1 force-pushed the improvement/disposable-signup-polish branch from dc19342 to fca8ab7 Compare October 31, 2026 18:36
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 0954143 into staging Oct 31, 2026
58 of 59 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/disposable-signup-polish branch October 31, 2026 18:43

This branch was previously deployed

1 inactive deployment
Preview — fca8ab70 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant