Skip to content

refactor(ui): make measurement styles explicit and reuse preview white #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 22, 2026
Merged

refactor(ui): make measurement styles explicit and reuse preview white #8142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ...kflowId]/components/panel/components/editor/components/sub-block/components/code/code.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,19 +564,19 @@ export const Code = memo(function Code({
const newVisualLineHeights: number[] = []

const tempContainer = document.createElement('div')
tempContainer.style.cssText = `
position: absolute;
visibility: hidden;
height: auto;
width: ${preElement.clientWidth}px;
font-family: ${window.getComputedStyle(preElement).fontFamily};
font-size: ${window.getComputedStyle(preElement).fontSize};
line-height: ${LINE_HEIGHT_PX}px;
padding: 8px;
white-space: pre-wrap;
word-break: break-word;
box-sizing: border-box;
`
Object.assign(tempContainer.style, {
position: 'absolute',
visibility: 'hidden',
height: 'auto',
width: `${preElement.clientWidth}px`,
fontFamily: window.getComputedStyle(preElement).fontFamily,
fontSize: window.getComputedStyle(preElement).fontSize,
lineHeight: `${LINE_HEIGHT_PX}px`,
padding: '8px',
whiteSpace: 'pre-wrap',
wordBreak: 'break-word',
boxSizing: 'border-box',
})
document.body.appendChild(tempContainer)

lines.forEach((line: string) => {
Expand Down
23 changes: 10 additions & 13 deletions ...nel/components/editor/components/sub-block/components/condition-input/condition-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,16 +466,16 @@ export function ConditionInput({

// Create a hidden container with the same width as the editor
const container = document.createElement('div')
container.style.cssText = `
position: absolute;
visibility: hidden;
width: ${preElement.clientWidth}px;
font-family: ${window.getComputedStyle(preElement).fontFamily};
font-size: ${window.getComputedStyle(preElement).fontSize};
padding: 12px;
white-space: pre-wrap;
word-break: break-word;
`
Object.assign(container.style, {
position: 'absolute',
visibility: 'hidden',
width: `${preElement.clientWidth}px`,
fontFamily: window.getComputedStyle(preElement).fontFamily,
fontSize: window.getComputedStyle(preElement).fontSize,
padding: '12px',
whiteSpace: 'pre-wrap',
wordBreak: 'break-word',
})
document.body.appendChild(container)

// Process each line
Expand All @@ -487,9 +487,6 @@ export function ConditionInput({
parts.forEach((part) => {
const span = document.createElement('span')
span.textContent = part
if (part.startsWith('<') && part.endsWith('>')) {
span.style.color = 'rgb(153, 0, 85)'
}
lineDiv.appendChild(span)
})
} else {
Expand Down
20 changes: 10 additions & 10 deletions .../editor/components/sub-block/components/tool-input/components/code-editor/code-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,16 @@ export function CodeEditor({
const newVisualLineHeights: number[] = []

const container = document.createElement('div')
container.style.cssText = `
position: absolute;
visibility: hidden;
width: ${preElement.clientWidth}px;
font-family: ${window.getComputedStyle(preElement).fontFamily};
font-size: ${window.getComputedStyle(preElement).fontSize};
padding: 12px;
white-space: pre-wrap;
word-break: break-word;
`
Object.assign(container.style, {
position: 'absolute',
visibility: 'hidden',
width: `${preElement.clientWidth}px`,
fontFamily: window.getComputedStyle(preElement).fontFamily,
fontSize: window.getComputedStyle(preElement).fontSize,
padding: '12px',
whiteSpace: 'pre-wrap',
wordBreak: 'break-word',
})
document.body.appendChild(container)

lines.forEach((line) => {
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/lib/pptx-renderer/core/viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ export class PptxViewer extends EventTarget {
box-shadow: 0 2px 8px rgba(0,0,0,0.15);
overflow: hidden;
position: relative;
background: #fff;
background: var(--white);
`

item.appendChild(wrapper)
Expand Down
Loading