refactor(ui): make measurement styles explicit and reuse preview white - #8142
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
Before/after visual verification at All 26 measured states matched in dimensions, wrapping, typography, colours, borders and shadows. The 14 images below cover light/dark themes, wide/narrow wrapped editors (including blank lines), and the PPTX wrapper. Additional blank-only and single-line states were measured. These are isolated browser fixtures using the real editor components and global CSS, with workspace/autocomplete services stubbed. The PPTX fixture uses the actual preview-wrapper method with sample slide content; this does not claim an end-to-end uploaded-presentation test. |














The workflow code, condition and tool code editors now assign their hidden measurement styles explicitly, preserving every layout value and measurement step. An unnecessary colour on hidden measurement text was removed, and the PPTX preview backing now uses the existing global white token. No visible change is intended.
Validation: all 26 workspace type checks, import resolution, API validation, changed-file lint, and 25 existing editor/PPTX tests pass. Browser comparisons of the real components in isolated fixtures match across 26 states, including both themes, wrapped/blank/single-line content and panel resizing. Workspace/autocomplete services are stubbed; the PPTX example tests the real preview wrapper with sample content. Fourteen before/after comparisons are attached in this comment.
This PR contains four product files only. Linter improvements and audit artifacts are maintained separately.
GitHub CI passes. Both Greptile and Cubic report 5/5 on the final commit. The external diff audit retains one warning for the PPTX wrapper’s existing interpolated CSS; no exception was added.