Skip to content

refactor(ui): make measurement styles explicit and reuse preview white - #8142

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-colour-assignments
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-colour-assignments

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

The workflow code, condition and tool code editors now assign their hidden measurement styles explicitly, preserving every layout value and measurement step. An unnecessary colour on hidden measurement text was removed, and the PPTX preview backing now uses the existing global white token. No visible change is intended.

Validation: all 26 workspace type checks, import resolution, API validation, changed-file lint, and 25 existing editor/PPTX tests pass. Browser comparisons of the real components in isolated fixtures match across 26 states, including both themes, wrapped/blank/single-line content and panel resizing. Workspace/autocomplete services are stubbed; the PPTX example tests the real preview wrapper with sample content. Fourteen before/after comparisons are attached in this comment.

This PR contains four product files only. Linter improvements and audit artifacts are maintained separately.

GitHub CI passes. Both Greptile and Cubic report 5/5 on the final commit. The external diff audit retains one warning for the PPTX wrapper’s existing interpolated CSS; no exception was added.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 5:32pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR refactors hidden workflow-editor measurement styles into explicit property assignments and reuses the global white token for PPTX preview framing. No behavioral regressions or actionable rule violations were identified.

  • Preserves the code, condition, and tool editor measurement dimensions and wrapping properties.
  • Removes a layout-neutral color assignment from hidden condition measurement text.
  • Replaces the PPTX preview wrapper’s literal white background with the application’s existing --white token.

Reviews (1) · Last reviewed commit: "refactor(ui): make measurement styles ex..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before/after visual verification at 17e415d1a3e38fb9. Left: before; right: after, captured together at the same zoom and theme.

All 26 measured states matched in dimensions, wrapping, typography, colours, borders and shadows. The 14 images below cover light/dark themes, wide/narrow wrapped editors (including blank lines), and the PPTX wrapper. Additional blank-only and single-line states were measured.

These are isolated browser fixtures using the real editor components and global CSS, with workspace/autocomplete services stubbed. The PPTX fixture uses the actual preview-wrapper method with sample slide content; this does not claim an end-to-end uploaded-presentation test.

Workflow code editor

code dark narrow

code-dark-narrow

code dark wide

code-dark-wide

code light narrow

code-light-narrow

code light wide

code-light-wide
Condition editor

condition dark narrow

condition-dark-narrow

condition dark wide

condition-dark-wide

condition light narrow

condition-light-narrow

condition light wide

condition-light-wide
Tool code editor

tool dark narrow

tool-dark-narrow

tool dark wide

tool-dark-wide

tool light narrow

tool-light-narrow

tool light wide

tool-light-wide
PPTX preview wrapper

pptx dark

pptx-dark

pptx light

pptx-light

@waleedlatif1
waleedlatif1 merged commit 2c96b88 into staging Sep 22, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-colour-assignments branch September 22, 2026 17:52

This branch was previously deployed

1 inactive deployment
Preview a3e38fb9 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants